Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct workflow #86

Merged
merged 45 commits into from
Apr 28, 2020
Merged

correct workflow #86

merged 45 commits into from
Apr 28, 2020

Conversation

EEngl52
Copy link
Collaborator

@EEngl52 EEngl52 commented Apr 7, 2020

Those are the easy changes to the worklow as discussed in the VC

Further tasks:

  • explain difference between clipping and resegment

  • probably change sequence of processing steps for block optimization

  • add links to available model repos and description of the most important models (https://wiki.de.dariah.eu/pages/viewpage.action?pageId=108140929 can be used as a starting point)

  • adjust the recommended workflows accordingly

kba
kba approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kba
Copy link
Member

kba commented Apr 9, 2020 •
edited
Loading

  • Add optional final step of format conversion with ocrd_fileformat

bertsky
bertsky requested changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest also discussing format conversion at the entry stage. (With pointers to our workspace terminology and METS/PAGE specs.) That is: TEI to METS, ALTO to PAGE, or even just image/PAGE directories (ocrd-import).

site/de/models.md Outdated Show resolved Hide resolved
site/de/models.md Outdated Show resolved Hide resolved
site/de/models.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
EEngl52 and others added 21 commits April 23, 2020 08:27
@EEngl52 @bertsky
Update site/de/models.md
2a96ce3 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/de/models.md
8c3ce20 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
daa21f6 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
29bcdcd 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
a064926 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
ebc389e 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
55e9274 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
7a73587 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
a9c2b3b 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
691983b 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
4ef45d4 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
bc8c651 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
9fb19c5 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
054bd62 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
0c978d8 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
8438162 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
3b4e3ed 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
849975e 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
d691256 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
8f3cd44 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52
add bertsky's suggestions
ce6d40d
EEngl52 and others added 13 commits April 23, 2020 13:57
@EEngl52
Merge branch 'new_workflow' of https://github.com/kba/ocrd-website in…
9a98292 
…to new_workflow

update branches
@kba
Modelle -> Schrift- und Sprachmodelle
23a6144
@kba
🎨 format redirect call in notes
d72f135
@kba
briefly describe @JKamlah/ocrd_pagetopdf
d523926
@kba
/de/models -> /de/modelle, formatting, models added to menu
11b6406
@kba
Merge branch 'master' into new_workflow
d4fa1e8
@kba
rebuild
a404953
@EEngl52 @bertsky
Update site/en/workflows.md
7250eb6 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
7f40977 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
96af9a8 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
39c9cf1 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
ba0f541 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
89eb7ab 
Co-Authored-By: Robert Sachunsky <[email protected]>
bertsky
bertsky requested changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the line breaks in the tables, IMO generally it would be advisable to use code plus pre to prevent newlines and have typewriter style.

site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
site/en/workflows.md Outdated Show resolved Hide resolved
EEngl52 and others added 5 commits April 28, 2020 15:48
@EEngl52
update workflows
2dbd45f
@EEngl52 @bertsky
Update site/en/workflows.md
60089aa 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
859c9b2 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
270b00e 
Co-Authored-By: Robert Sachunsky <[email protected]>
@EEngl52 @bertsky
Update site/en/workflows.md
9b8cc61 
Co-Authored-By: Robert Sachunsky <[email protected]>
@kba kba merged commit b44f2b6 into master Apr 28, 2020
@kba
Copy link
Member

kba commented Apr 28, 2020

Thanks @EEngl52 for improving the workflow docs and @bertsky for multiple rounds of reviews. I hope we caught all your comments. If we missed something, don't hesitate to comment here or in a new issue.

@kba kba deleted the new_workflow branch April 28, 2020 17:37
@bertsky
Copy link
Collaborator

bertsky commented Apr 28, 2020

If we missed something, don't hesitate to comment here or in a new issue.

Actually, I was hoping for the above checks to be filled, esp.:

* adjust the recommended workflows accordingly

Since in GH I cannot comment/suggest outside of patch contexts, I have added my comments to the commit I found responsible via blame today, cf. b0eeb7a#commitcomment-38800544

Does anyone know who gets these and how I can control this? What's the proper way to do that within the PR context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

@bertsky bertsky bertsky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EEngl52 @kba @bertsky