Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: multi-version CUDA #704

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Docker: multi-version CUDA #704

merged 4 commits into from
Feb 4, 2022

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Jul 23, 2021

Implements ideas laid out in OCR-D/ocrd_all#263

  • rebase CUDA image on newest Nvidia runtime
  • add a fixup that installs all CUDA RT versions

Dockerfile Show resolved Hide resolved
@bertsky
Copy link
Collaborator Author

bertsky commented Jul 23, 2021

Strange. The CI failures do not look related at all:

_____________________ TestDecorators.test_loglevel_invalid _____________________

self = <tests.test_decorators.TestDecorators testMethod=test_loglevel_invalid>

    def test_loglevel_invalid(self):
        code, _, err = self.invoke_cli(cli_with_ocrd_loglevel, ['--log-level', 'foo'])
        assert code
>       self.assertIn('invalid choice: foo', err)
E       AssertionError: 'invalid choice: foo' not found in "Usage: python -m pytest [OPTIONS]\nTry 'python -m pytest --help' for help.\n\nError: Invalid value for '-l' / '--log-level': 'foo' is not one of 'OFF', 'ERROR', 'WARN', 'INFO', 'DEBUG', 'TRACE'.\n"

tests/test_decorators.py:55: AssertionError
____________________________ TestOcrdExif.test_png1 ____________________________

self = <tests.model.test_exif.TestOcrdExif testMethod=test_png1>

    def test_png1(self):
        with Image.open(assets.path_to('kant_aufklaerung_1784-binarized/data/OCR-D-IMG-BIN/BIN_0020.png')) as img:
            exif = OcrdExif(img)
        self.assertEqual(exif.width, 1457)
        self.assertEqual(exif.height, 2084)
>       self.assertEqual(exif.xResolution, 295)
E       AssertionError: 294 != 295

tests/model/test_exif.py:37: AssertionError

Ah, master has the same problems.

@kba
Copy link
Member

kba commented Jul 24, 2021

Ah, master has the same problems.

Oh dang, I'll fix that. Something changed between Pillow 8.1.2 and 8.3.1.

Update: Is fixed in master now.

@kba kba merged commit 1a7b81c into OCR-D:master Feb 4, 2022
@bertsky bertsky deleted the multi-cuda branch June 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants