-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocrd_network base integration tests #1164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, great work. a few minor questions, but ready for merge AFAICS. I'm running the tests and making sure that the multi-stage setup does not interfere with our other Docker deployments.
macos: I'll try to get it to work but it's not a blocker.
healthcheck: | ||
test: echo 'db.runCommand("ping").ok' | mongosh localhost:27017/test --quiet | ||
interval: 1s | ||
timeout: 3s | ||
retries: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that is a useful pattern we should apply widely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that works, I prefer using that instead of sleeping here and there to wait. So far I have not seen issues with that health check here and in Operandi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This are my first comments after I read through the changed source-code. I still have to find out why the tests fail on my side and then I will comment again.
Good to be shipped. |
This PR is just a basic beginning for the
ocrd_network
integration tests.What does this PR include:
ocrd_network
for easier testing of the DB functionalitiesUNSET
for jobs for easier testing instead of relying onNone
/
for just testing the connectivity to the Processing Server/workflow/job-simple/{workflow_job_id}
- simplified endpoint for checking the overall status of a workflowocrd-dummy
processor and queue by default when started:ocrd_network
and adding a dedicated endpointconftest.py
provided for using fixtures for the MongoDB and RabbitMQocrd-dummy
processorsocrd-dummy
(1 processing worker deployed)ocrd_logging.conf
for the ocrd_network integration tests for easier catching of bugs when tests are failing.dockerignore
to include relevant parts for the testsocrd_core_test
image to be used by the testing containersmake integration-test
call