[16.0][FW] stock_storage_type: port changes from 14 #948
Conversation
|
Hi @jbaudoux, @rousseldenis, |
| @@ -18,6 +18,15 @@ class StockQuantPackage(models.Model): | |||
| compute="_compute_height_in_m", | |||
| store=True, | |||
| ) | |||
| package_storage_type_id = fields.Many2one( | |||
There was a problem hiding this comment.
@henrybackman @grindtildeath What is the behavior on an existing database ?
IMHO, this compute will last a long time
There was a problem hiding this comment.
You can blacklist all those changes, it's all covered.
What has been lost in the migration is the max_height field on the stock.storage.category. It's in the model but not in the view. Can be added after themax_weight.
Ideally all remaining mentions to location_storage_types should be renamed to location_category to make the code clearer. FYI the relation is now one instead of multi.
Finally, I wish to move changes to StorageCategoryProductCapacity to a new object. I can explain you in details if you want to help on this.
| access_stock_location_storage_type_user,access_stock_location_storage_type_user,model_stock_location_storage_type,base.group_user,1,0,0,0 | ||
| access_stock_package_storage_type_user,access_stock_package_storage_type_user,model_stock_package_storage_type,base.group_user,1,0,0,0 | ||
| access_stock_location_storage_type_manager,access_stock_location_storage_type_manager,model_stock_location_storage_type,stock.group_stock_manager,1,1,1,1 | ||
| access_stock_package_storage_type_manager,access_stock_package_storage_type_manager,model_stock_package_storage_type,stock.group_stock_manager,1,1,1,1 | ||
| access_stock_location_package_storage_type_rel_user,access_stock_location_package_storage_type_rel_user,model_stock_location_package_storage_type_rel,base.group_user,1,0,0,0 | ||
| access_stock_location_package_storage_type_rel_manager,access_stock_location_package_storage_type_rel_manager,model_stock_location_package_storage_type_rel,base.group_user,1,1,1,1 |
There was a problem hiding this comment.
All those models are gone in v16
| @@ -18,6 +18,15 @@ class StockQuantPackage(models.Model): | |||
| compute="_compute_height_in_m", | |||
| store=True, | |||
| ) | |||
| package_storage_type_id = fields.Many2one( | |||
There was a problem hiding this comment.
it is already there in standard and now named package_type_id
| "quant_ids.product_id", | ||
| "quant_ids.product_id.product_package_storage_type_id", | ||
| ) | ||
| def _compute_package_storage_type_id(self): |
There was a problem hiding this comment.
It's already there in v16: https://github.com/OCA/wms/blob/16.0/stock_storage_type/models/stock_quant_package.py#L56
henrybackman
force-pushed
the
16-port-from-14-stock_storage_type
branch
from
217c46e
to
81e6071
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 9cd26e2. Thanks a lot for contributing to OCA. ❤️ |
Port changes from 14.0 to 16.0. (No PRs)
The following PRs have been blacklisted: