[14.0][IMP] shopfloor zone picking improve select_line endpoint/state #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
requested changes
Aug 21, 2023
Comment on lines
632
to
641
| if ( | ||
| this.state.data.scan_location_or_pack_first && | ||
| !sublocation | ||
| !sublocation && | ||
| !pack | ||
| ) { | ||
| if (this.all_lines_with_package()) { | ||
| return "Scan pack"; | ||
| } | ||
| return "Scan location / pack"; | ||
| } |
There was a problem hiding this comment.
if (this.state.data.scan_location_or_pack_first)
if (!pack && this.all_lines_with_package() {
return "Scan pack";
}
if (!sublocation && !pack) {
return "Scan location / pack";
}
if (any_line_with_lot) {
return "Scan product / lot";
} else {
return "Scan product";
}
}
TDu
force-pushed
the
14-sf-zp-scan-at-least-one-prodcut
branch
from
776f2ca
to
8e31839
Compare
jbaudoux
reviewed
Aug 22, 2023
Comment on lines
661
to
788
| return "Scan product / pack / lot"; | ||
| } | ||
| return "Scan product / pack"; | ||
| } |
There was a problem hiding this comment.
pack / product / lot
Why having pack after product? Or product / lot / pack
pack / product ?
jbaudoux
approved these changes
Aug 23, 2023
|
@TDu Can you squash the fixups? |
TDu
force-pushed
the
14-sf-zp-scan-at-least-one-prodcut
branch
from
f8a60b5
to
1863d4c
Compare
|
squashed |
On line selection for the zone picking scenario. Without this change the user may move a product without ever scanning the product barcode or lot. Because after scanning scanning a packge if only one line is left the next screen with the quantity picker is shown to the user, where the quantity can be changed manually or by scanning a product.
jbaudoux
force-pushed
the
14-sf-zp-scan-at-least-one-prodcut
branch
from
e9d295c
to
9fb2f85
Compare
|
rebased |
mmequignon
approved these changes
Aug 28, 2023
|
This PR has the |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d5cb57d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref.: rau-214 rau-215