[16.0][MIG] web_widget_x2many_2d_matrix #2463

tarteo · 2023-03-21T14:24:38Z

No description provided.

tarteo · 2023-03-21T14:41:34Z

/ocabot migration web_widget_x2_many_2d_matrix

tarteo · 2023-03-21T14:42:53Z

I'll also migrate the timesheet sheet module (hr_timesheet_sheet).

astirpe

@tarteo thank you for this great work! The code looks very clean now.

We are all eager to test it with the timesheet sheet module 😉

web_widget_x2many_2d_matrix/__manifest__.py

legalsylvain · 2023-03-21T15:14:41Z

Hi @tarteo. Thanks for porting this usefull module.
could you take a look on open PRs that bring some fixes or improvments ? and cherry pick the interesting commits ? specially on V15 modules :

[15.0][IMP] web_widget_x2many_2d_matrix: option to control the location of the total column #2380 by @vincent-hatakeyama
[15.0][IMP] web_widget_x2many_2d_matrix: Include currency for formatting monetary values in row/column sums #2379 by @vincent-hatakeyama
[15.0][FIX] web_widget_x2many_2d_matrix: fix totals option #2361 by @vincent-hatakeyama

Thanks !

astirpe

Code review: LGTM!
Functional test: by testing the timesheet sheet widget of OCA/timesheet#580 I implicitly tested this matrix module and it works properly
Thanks!

tarteo · 2023-03-28T15:08:17Z

@legalsylvain I'm currently working on something else so I don't have time to implement extra features now. I think some PRs fixing things are already fixed by the migration. Can you please review the migation as is. Thanks! 😄

sonhd91 · 2023-04-25T09:50:34Z

...get_x2many_2d_matrix/static/src/components/x2many_2d_matrix_field/x2many_2d_matrix_field.xml

+                matrixFields="props.matrixFields"
+                showRowTotals="props.showRowTotals"
+                showColumnTotals="props.showColumnTotals"
+                setDirty="props.setDirty"


Suggested change

setDirty="props.setDirty"

setDirty="(isDirty) => this.setDirty(isDirty)"

fixed this error

`UncaughtPromiseError > OwlError Uncaught Promise > Invalid props for component 'X2Many2DMatrixRenderer': 'setDirty' is undefined (should be a function) OwlError: Invalid props for component 'X2Many2DMatrixRenderer': 'setDirty' is undefined (should be a function) at Object.validateProps (http://localhost:8069/web/assets/debug/web.assets_common.js:19239:19) (/web/static/lib/owl/owl.js:3069) at X2Many2DMatrixField.template (eval at compile (http://localhost:8069/web/assets/debug/web.assets_common.js:21606:16), <anonymous>:11:13) (/web/static/lib/owl/owl.js:5436) at Fiber._render (http://localhost:8069/web/assets/debug/web.assets_common.js:17791:38) (/web/static/lib/owl/owl.js:1621) at Fiber.render (http://localhost:8069/web/assets/debug/web.assets_common.js:17783:18) (/web/static/lib/owl/owl.js:1613) at ComponentNode.initiateRender (http://localhost:8069/web/assets/debug/web.assets_common.js:18505:23) (/web/static/lib/owl/owl.js:2335)`

Reproduce

Create wizard like in README

Add action to menu-action open the wizard form, error showup

Thanks! I'll fix it.

Should be fixed now

@sonhd91 is it ok for you now? Can you approve this PR?

Saran440 · 2023-04-26T06:49:56Z

Hi,

In v16, It error

with my code

<field
    name="line_ids"
    widget="x2many_2d_matrix"
    field_x_axis="date_range_id"
    field_y_axis="name"
    field_value="amount"
>
    <tree>
        <field name="date_range_id" />
        <field name="name" />
        <field name="amount" />
    </tree>
</field>

result in v15

PieterPaulussen · 2023-04-29T11:16:57Z

Code review: Broken
I've tested the module thoroughly and support for a Many2one value field is missing. I've created a PR to address the issue here, although I personally think it still falls short of the features it should have.

Features that need be restored/added/updated:

Add possibility to specify the aggregation field type (int, float, ...). Current code version uses the same field type to display the aggregation value. There is also no check to validate if the row or column CAN be aggregated at all (which seemed to be present in older versions?)
The use of the word list seems confusing. I've refactored the use of list to matrixRows which seems more appropriate and clarifies its purpose.

tarteo · 2023-05-10T12:36:00Z

@PieterPaulussen You realize I did a complete rewrite of this field widget?

Add possibility to specify the aggregation field type (int, float, ...). Current code version uses the same field type to display the aggregation value. There is also no check to validate if the row or column CAN be aggregated at all (which seemed to be present in older versions?)

This is certainly not the case in previous versions. You can't differ from the aggregated field type. Checking if the field can be aggregated is literally one line of code, please calm down...

The use of the word list seems confusing. I've refactored the use of list to matrixRows which seems more appropriate and clarifies its purpose.

list is not the matrix it's a list of records. there's a different variable for it called "matrix" in X2Many2DMatrixRenderer. Lists are different from matrices.

tarteo · 2023-05-10T12:36:49Z

@Saran440 Thanks I'll look into it.

tarteo · 2023-05-11T12:22:48Z

Hey @Saran440 It should be fixed now

Saran440

Functional Test 👍

ghost · 2023-05-28T10:35:58Z

Functional test with web_widget_x2many_2d_matrix_example: 👍 for simple field. 👎 for selection and many2one fields.

tarteo · 2023-05-30T07:11:04Z

@appstogrow Thanks I think I can look at it this week. Using your migration of the example module, thanks! I only tested it with the timesheet sheet module.

ernestotejeda

Tested on web_widget_x2many_2d_matrix_example #2520 👍🏼

pedrobaeza · 2023-06-07T07:05:02Z

@tarteo are you going to check the m2o case?

tarteo · 2023-06-07T13:44:05Z

@pedrobaeza yes

pedrobaeza · 2023-06-07T13:48:39Z

Great, thanks.

/ocabot merge nobump

OCA-git-bot · 2023-06-07T13:48:50Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2463-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

MiquelRForgeFlow · 2023-06-07T13:55:30Z

Merge should be stopped and restarted. @pedrobaeza

OCA-git-bot · 2023-06-07T13:56:58Z

Congratulations, your PR was merged at 749d0f5. Thanks a lot for contributing to OCA. ❤️

MiquelRForgeFlow · 2023-06-07T13:57:10Z

@sbidoul we should implement an option of /ocabot merge stop for these cases

OCA-git-bot · 2023-06-07T13:57:12Z

Hi @MiquelRForgeFlow. Your command failed:

Invalid options for command merge: stop for these cases.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

MiquelRForgeFlow · 2023-06-07T14:00:09Z

@tarteo a new PR should be done to add your last commit!

tarteo · 2023-06-07T14:03:42Z

Just pushed a fix for many2one functionality

OCA-git-bot · 2023-06-07T14:04:31Z

Hi @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!

OCA-git-bot · 2023-06-07T14:09:57Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tarteo · 2023-06-07T14:12:49Z

/ocabot merge minor

OCA-git-bot · 2023-06-07T14:12:56Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2463-by-tarteo-bump-minor, awaiting test results.

OCA-git-bot · 2023-06-07T14:16:45Z

Congratulations, your PR was merged at 999c085. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 16.0 milestone Mar 21, 2023

OCA-git-bot mentioned this pull request Mar 21, 2023

Migration to version 16.0 #2309

Open

46 tasks

astirpe suggested changes Mar 21, 2023

View reviewed changes

web_widget_x2many_2d_matrix/__manifest__.py Outdated Show resolved Hide resolved

tarteo force-pushed the 16-mig-matrix-widget branch from 1e01f57 to 36f816e Compare March 22, 2023 13:17

tarteo mentioned this pull request Mar 22, 2023

[16.0][MIG] hr_timesheet_sheet OCA/timesheet#580

Merged

tarteo changed the title ~~[16.0][MIG] web_widget_x2_many_2d_matrix~~ [16.0][MIG] web_widget_x2many_2d_matrix Mar 22, 2023

tarteo force-pushed the 16-mig-matrix-widget branch 2 times, most recently from 7af8d48 to 8617984 Compare March 22, 2023 14:32

astirpe approved these changes Mar 24, 2023

View reviewed changes

sonhd91 reviewed Apr 25, 2023

View reviewed changes

Saran440 mentioned this pull request Apr 28, 2023

[WIP][16.0][ADD] budget_control OCA/account-budgeting#67

Closed

11 tasks

PieterPaulussen mentioned this pull request Apr 29, 2023

[FIX] web_widget_x2many_2d_matrix: support One2many field as value field tarteo/web#13

Open

tarteo force-pushed the 16-mig-matrix-widget branch from 8617984 to 33b5aa7 Compare May 11, 2023 12:21

tarteo force-pushed the 16-mig-matrix-widget branch 2 times, most recently from b9d3f0e to feee650 Compare May 11, 2023 12:58

Saran440 approved these changes May 12, 2023

View reviewed changes

OCA-git-bot added the approved label May 12, 2023

ghost mentioned this pull request May 28, 2023

[16.0][MIG] web_widget_x2many_2d_matrix_example #2520

Closed

LoisRForgeFlow mentioned this pull request Jun 6, 2023

[16.0][MIG] mrp_planned_order_matrix OCA/manufacture#898

Merged

ernestotejeda approved these changes Jun 6, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 7, 2023

OCA-git-bot added a commit that referenced this pull request Jun 7, 2023

Merge PR #2463 into 16.0

08f75da

Signed-off-by pedrobaeza

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 7, 2023

OCA-git-bot closed this Jun 7, 2023

tarteo reopened this Jun 7, 2023

OCA-git-bot added the ready to merge label Jun 7, 2023

tarteo added 2 commits June 7, 2023 16:12

[IMP] web_widget_x2many_2d_matrix: Check is aggregatable

ef51367

[IMP] web_widget_x2many_2d_matrix: Many2one value field

476fe9a

tarteo force-pushed the 16-mig-matrix-widget branch from d32fa9b to 476fe9a Compare June 7, 2023 14:12

OCA-git-bot added the bot is merging ⏳ label Jun 7, 2023

OCA-git-bot merged commit 88c5d19 into OCA:16.0 Jun 7, 2023

OCA-git-bot removed the bot is merging ⏳ label Jun 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] web_widget_x2many_2d_matrix #2463

[16.0][MIG] web_widget_x2many_2d_matrix #2463

tarteo commented Mar 21, 2023

tarteo commented Mar 21, 2023

tarteo commented Mar 21, 2023

astirpe left a comment

legalsylvain commented Mar 21, 2023

astirpe left a comment

tarteo commented Mar 28, 2023

sonhd91 Apr 25, 2023 •

edited

Loading

tarteo May 10, 2023

tarteo May 11, 2023

astirpe May 23, 2023

Saran440 commented Apr 26, 2023

PieterPaulussen commented Apr 29, 2023

tarteo commented May 10, 2023

tarteo commented May 10, 2023

tarteo commented May 11, 2023

Saran440 left a comment

ghost commented May 28, 2023

tarteo commented May 30, 2023 •

edited

Loading

ernestotejeda left a comment

pedrobaeza commented Jun 7, 2023

tarteo commented Jun 7, 2023

pedrobaeza commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023 •

edited

Loading

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023

tarteo commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

tarteo commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

	setDirty="props.setDirty"
	setDirty="(isDirty) => this.setDirty(isDirty)"

[16.0][MIG] web_widget_x2many_2d_matrix #2463

[16.0][MIG] web_widget_x2many_2d_matrix #2463

Conversation

tarteo commented Mar 21, 2023

tarteo commented Mar 21, 2023

tarteo commented Mar 21, 2023

astirpe left a comment

Choose a reason for hiding this comment

legalsylvain commented Mar 21, 2023

astirpe left a comment

Choose a reason for hiding this comment

tarteo commented Mar 28, 2023

sonhd91 Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

tarteo May 10, 2023

Choose a reason for hiding this comment

tarteo May 11, 2023

Choose a reason for hiding this comment

astirpe May 23, 2023

Choose a reason for hiding this comment

Saran440 commented Apr 26, 2023

PieterPaulussen commented Apr 29, 2023

tarteo commented May 10, 2023

tarteo commented May 10, 2023

tarteo commented May 11, 2023

Saran440 left a comment

Choose a reason for hiding this comment

ghost commented May 28, 2023

tarteo commented May 30, 2023 • edited Loading

ernestotejeda left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jun 7, 2023

tarteo commented Jun 7, 2023

pedrobaeza commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023 • edited Loading

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

MiquelRForgeFlow commented Jun 7, 2023

tarteo commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

tarteo commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

sonhd91 Apr 25, 2023 •

edited

Loading

tarteo commented May 30, 2023 •

edited

Loading

MiquelRForgeFlow commented Jun 7, 2023 •

edited

Loading