Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][16.0] fs_document #322

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[ADD][16.0] fs_document #322

wants to merge 1 commit into from

Conversation

gbrito
Copy link

@gbrito gbrito commented Jan 12, 2024

Odoo with the document app introduces changes on how the document.document interacts with ir.attachment

This module will fix issue #313

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@asanjuan-kernet
Copy link

asanjuan-kernet commented Jun 5, 2024 •
edited
Loading

Had the exact same issue and couldn't download documents either, this fixed them both. Any updated on it?
Thanks for your work

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
lmignon
lmignon reviewed Nov 10, 2024
View reviewed changes
fs_document/__manifest__.py
"summary": "Enable fetching external stored document.document",
"version": "16.0.1.0.0",
"author": "ERP|OPEN B.V. , Odoo Community Association (OCA)",
"license": "AGPL-3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addon depends on an enterprise one. The AGPL licence is not compatible with the OEEL-1 licence.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon maybe i can add the if statement on the base module. Ir the document module is not installed it will still work

lmignon
lmignon reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this usefull glue addon between fs_attachment and the documents addon from Odoo enterprise. Since the CI and our runboat infrastructure have no access to the Enterprise addons we must find a way to manage this kind of addons.

@lmignon lmignon added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon left review comments

Assignees
No one assigned
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbrito @asanjuan-kernet @lmignon