-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] tms_account: Analytic configuration #153
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @EdgarRetes, @santiagordz, |
/ocabot rebase |
@max3903 The rebase process failed, because command
|
6456066
to
4b05d42
Compare
Same here. Not to bother but to ensure commit history is clean on main branches and respect OCA conventions. Thanks |
@EdgarRetes Can you review this one as well please? |
It works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't saw anything that could break, just notice the @api.model on all create and write methods. Shouldn't we change the create method to model_create_multi and remove the one from the write method?
Probably this will impact the rest of the modules that depend/ inherit this one?
@gbrito Thanks for the review. There is not much modules depending on it yet. CC: @EdgarRetes |
Depends on: