-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sale_input_barcode: scan directly on sale.order #611
base: 14.0
Are you sure you want to change the base?
Conversation
Hi @bealdav, |
30e8dff
to
71ac748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok!
I have to dive in. |
71ac748
to
b757f4c
Compare
Hi @bealdav , could you take a look at this? It makes the module much more usable as per features described in the first comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
@OCA/logistics-maintainers could you please take a look? thank you! |
It seems a good idea to have an option to adjust quantity when the same product is added but I think it should be an option because you may want to create a new line (the initial object of the module when I created it) The way you did it can the default behavior but I suppose that we can propose the previous to do it with a context in the wizard ? Could you implement both behavior ? Thanks a lot |
sale.order
form