Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_input_barcode: scan directly on sale.order #611

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

renda-dev
Copy link

  • Add the possibility to directly scan barcodes on the sale.order form
  • If you scan the same product twice, it will adjust the product quantity instead of creating a new line

@OCA-git-bot
Copy link
Contributor

Hi @bealdav,
some modules you are maintaining are being modified, check this out!

@renda-dev renda-dev force-pushed the 14.0-imp-sale_input_barcode branch from 30e8dff to 71ac748 Compare May 10, 2024 10:42
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@bealdav
Copy link
Member

bealdav commented Sep 5, 2024

I have to dive in.

@francesco-ooops
Copy link
Contributor

Hi @bealdav , could you take a look at this? It makes the module much more usable as per features described in the first comments

Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@francesco-ooops
Copy link
Contributor

@OCA/logistics-maintainers could you please take a look? thank you!

@bealdav
Copy link
Member

bealdav commented Nov 15, 2024

If you scan the same product twice, it will adjust the product quantity instead of creating a new line

It seems a good idea to have an option to adjust quantity when the same product is added but I think it should be an option because you may want to create a new line (the initial object of the module when I created it)

The way you did it can the default behavior but I suppose that we can propose the previous to do it with a context in the wizard ?
You may also implement an option in the company or in the ir.config.parameter.

Could you implement both behavior ?

Thanks a lot

cc @matthieusaison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants