Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] sale_coupon_sale_order_based #54

Merged
merged 1 commit into from
May 30, 2022
Merged

[14.0][ADD] sale_coupon_sale_order_based #54

merged 1 commit into from
May 30, 2022

Conversation

ivs-cetmix
Copy link
Member

Sales Order based domain for Sales Coupon

@elvise
Copy link

elvise commented May 8, 2022

@sbidoul can you check what happen here with the runboat?

thanks in advance for your support

@sbidoul
Copy link
Member

sbidoul commented May 8, 2022

Runboat was enjoying a sunny week-end :) Nah, actually there was something super weird going on: OCA/oca-ci#29, so I had to shut it down to recover.

I manually triggered a build for this PR.

@elvise
Copy link

elvise commented May 8, 2022 •
edited
Loading

@sbidoul thanks so much man! :)

francesco-ooops
francesco-ooops approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

elvise
elvise approved these changes May 9, 2022
View reviewed changes
Copy link

@elvise elvise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@chienandalu any opinion on this one?

@francesco-ooops
Copy link
Contributor

@OCA/crm-sales-marketing-maintainers

@elvise
Copy link

elvise commented May 18, 2022

@OCA/crm-sales-marketing-maintainers is there a good soul who can make a review? :)

@elvise
Copy link

elvise commented May 20, 2022

@rousseldenis would be great if can check this PR :)

@elvise
Copy link

elvise commented May 23, 2022

@pedrobaeza can you check this PR ? Thanks :)

chienandalu
chienandalu approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested and code looks good 👍

@pedrobaeza pedrobaeza added this to the 14.0 milestone May 24, 2022
@pedrobaeza
Copy link
Member

For being consistent with other existing methods and for shorten the name, I would go with sale_coupon_criteria_order_based

@francesco-ooops
Copy link
Contributor

alright, @isserver1 can you change?

@GabbasovDinar GabbasovDinar force-pushed the 14.0-add_sale_coupon_sale_order_based branch from 8c438ba to 0ba22cc Compare May 26, 2022 18:13
@GabbasovDinar
Copy link
Member

@simahawk done

@GabbasovDinar GabbasovDinar force-pushed the 14.0-add_sale_coupon_sale_order_based branch 2 times, most recently from 3c0482c to f01efeb Compare May 26, 2022 20:04
simahawk
simahawk requested changes May 27, 2022
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash once your done w/ the changes?

sale_coupon_criteria_order_based/__manifest__.py Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/models/coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/models/coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/models/coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/models/coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
sale_coupon_criteria_order_based/readme/HISTORY.rst Outdated Show resolved Hide resolved
@GabbasovDinar GabbasovDinar force-pushed the 14.0-add_sale_coupon_sale_order_based branch 2 times, most recently from 9f79690 to 9684f68 Compare May 28, 2022 15:22
@GabbasovDinar GabbasovDinar force-pushed the 14.0-add_sale_coupon_sale_order_based branch from 9684f68 to a282838 Compare May 28, 2022 15:30
@GabbasovDinar
Copy link
Member

@simahawk ready for review

@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-54-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 583f9b7 into OCA:14.0 May 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a523d60. Thanks a lot for contributing to OCA. ❤️

@GabbasovDinar GabbasovDinar deleted the 14.0-add_sale_coupon_sale_order_based branch May 31, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabbasovDinar GabbasovDinar GabbasovDinar left review comments

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@elvise elvise elvise approved these changes

@chienandalu chienandalu chienandalu approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ivs-cetmix @elvise @sbidoul @OCA-git-bot @francesco-ooops @pedrobaeza @GabbasovDinar @simahawk @chienandalu