Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] report_xlsx_helper: Migration to 16.0 #655

Merged
merged 53 commits into from
Dec 5, 2022
Merged

[16.0][MIG] report_xlsx_helper: Migration to 16.0 #655

merged 53 commits into from
Dec 5, 2022

Conversation

RodrigoBM
Copy link
Contributor

@RodrigoBM RodrigoBM commented Oct 6, 2022 •
edited
Loading

@oca-clabot
Copy link

Hey @RodrigoBM, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@RodrigoBM
Copy link
Contributor Author

/ocabot migration report_xlsx_helper

@OCA-git-bot
Copy link
Contributor

Sorry @RodrigoBM you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@RodrigoBM RodrigoBM mentioned this pull request Oct 6, 2022
Open
15 tasks
@baimont
Copy link

baimont commented Oct 10, 2022

Hi @RodrigoBM,
Thanks for this pr.

Can you fix red pre-commit and add report_xlsx to test-requirements.txt to fix runboat and tests?

Inspiration can be found there : OCA/queue@33cf163

Thanks!

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-report_xlsx_helper branch 2 times, most recently from 876354a to db7a9c2 Compare October 11, 2022 08:41
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-report_xlsx_helper branch 3 times, most recently from 81d8b10 to 503fda4 Compare October 11, 2022 09:08
@RodrigoBM
Copy link
Contributor Author

Hi @baimont

I hope this is OK now. But I don't know why the "tests / Detect unreleased dependencies (pull_request)" doesn't work.

Regards

@baimont
Copy link

baimont commented Oct 11, 2022

Hi @baimont

I hope this is OK now. But I don't know why the "tests / Detect unreleased dependencies (pull_request)" doesn't work.

Regards

Hi @RodrigoBM
Thanks for your changes.
This is normal.
tests / Detect unreleased dependencies is there to remind you you'll have to remove the last commit once your dependency is merged.

@RodrigoBM
Copy link
Contributor Author

Okey,
Thanks @baimont

@RodrigoBM RodrigoBM mentioned this pull request Oct 17, 2022
Merged
StefanRijnhart and others added 15 commits December 4, 2022 17:08
@StefanRijnhart @RodrigoBM
[FIX] report_xlsx_helper: force Libreoffice to recompute formulas
6ab69e3 
As per https://xlsxwriter.readthedocs.io/faq.html:

Q. Why do my formulas show a zero result in some, non-Excel applications?
A. [...] Or, you can set a blank result in the formula, which will also force
recalculation.
@anasuarez1 @RodrigoBM
Added translation using Weblate (Spanish)
bef89f8
@anasuarez1 @RodrigoBM
Translated using Weblate (Spanish)
2591c55 
Currently translated at 7.1% (1 of 14 strings)

Translation: reporting-engine-14.0/reporting-engine-14.0-report_xlsx_helper
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_xlsx_helper/es/
@OCA-git-bot @RodrigoBM
report_xlsx_helper 14.0.1.0.1
e6240f6
@RodrigoBM
[IMP] report_xlsx_helper: black, isort, prettier
9688c16
@RodrigoBM
[MIG] report_xlsx_helper: Migration to 15.0
fb127bb
@RodrigoBM
[UPD] Update report_xlsx_helper.pot
3191736
@OCA-git-bot @RodrigoBM
[UPD] README.rst
7e3aa0c
@manuelregidor @RodrigoBM
[FIX]report_xlsx_helper: Development status mature
da20e1e
@OCA-git-bot @RodrigoBM
[UPD] README.rst
21fda66
@OCA-git-bot @RodrigoBM
report_xlsx_helper 15.0.1.0.1
c8fc00e
@jabelchi @RodrigoBM
Added translation using Weblate (Catalan)
17b5e59
@jabelchi @RodrigoBM
Translated using Weblate (Catalan)
d6a8482 
Currently translated at 72.7% (8 of 11 strings)

Translation: reporting-engine-15.0/reporting-engine-15.0-report_xlsx_helper
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xlsx_helper/ca/
@RodrigoBM
[IMP] : black, isort, prettier
648867a
@RodrigoBM
[MIG] report_xlsx_helper: Migration to 16.0
d924b58
@RodrigoBM RodrigoBM changed the title [MIG] report_xlsx_helper: Migration to 16.0 [16.0][MIG] report_xlsx_helper: Migration to 16.0 Dec 4, 2022
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration report_xlsx_helper
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 5, 2022
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-655-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba84a0a into OCA:16.0 Dec 5, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at babc717. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-report_xlsx_helper branch December 5, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoRomera FernandoRomera FernandoRomera approved these changes

@baimont baimont baimont approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.