[16.0][FIX] product_supplierinfo_stock_picking_type: rename on change picking type method #1777
Conversation
|
Hi @victoralmau, |
AlexPForgeFlow
changed the title
AlexPForgeFlow
force-pushed
the
16.0-fix-product_supplierinfo_stock_picking_type
branch
from
5c9f2eb
to
7e35f92
Compare
… picking type method
AlexPForgeFlow
force-pushed
the
16.0-fix-product_supplierinfo_stock_picking_type
branch
from
7e35f92
to
476055a
Compare
| def onchange_picking_type_id(self): | ||
| def onchange_picking_type_id_onchange_product(self): | ||
| # Method name is to avoid conflicts with mrp_subcontracting_dropshipping | ||
| # that have an onchange method named onchange_picking_type_id |
There was a problem hiding this comment.
I think you can keep the same method but call the super if the method exists.
if hasattr(super(), "onchange_picking_type_id"):
getattr(super(), "onchange_picking_type_id)
There was a problem hiding this comment.
Hi @victoralmau !
No, as I already mentioned, the Odoo function is overriding the method, so in the module hierarchy, product_supplierinfo_stock_picking_type comes before mrp_subcontracting_dropshipping. For this reason, the method is being overridden. To implement your solution, we would need to add it to Odoo's method.
|
This PR has the |
If module mrp_subcontracting_dropshipping, form Odoo, is installed in our system, there are conflicts between onchange methods, mrp_subcontracting_dropshipping method https://github.com/odoo/odoo/blob/16.0/addons/mrp_subcontracting_dropshipping/models/purchase.py#L23 is overriding the onchange method previously defined in this module. So I suggest renaming the onchange method.