Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] CONTRIBUTING.rst: oca_dependencies.txt in the repo root folder #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norlinhenrik
Copy link
Contributor

No description provided.

@rousseldenis
Copy link

@norlinhenrik For a while that one has been replaced by requirements.txt (automatically generated) and test-requirements.txt for open PR dependencies.

@norlinhenrik
Copy link
Contributor Author

requirements.txt is for python dependencies.
oca_dependencies.txt is for OCA repo dependencies.

@norlinhenrik
Copy link
Contributor Author

Which tools are using oca_dependencies.txt?

Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing commit description.

@norlinhenrik
Copy link
Contributor Author

@luisg123v The commit description is in the name. I never added any description in a commit. How do you do that?

@luisg123v
Copy link
Contributor

@norlinhenrik,

I mean, the commit message should be a commit title, followed by a blank line, followed by a description. Usually, the title is a short summary of the change (the what), while the commit message can include more details, the rationale, etc (the why and the how).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants