[IMP][16.0] mis_builder: use company of report.instance when querying #625
Conversation
|
Hi @sbidoul, |
AnizR
changed the title
|
This PR has the |
AnizR
force-pushed
the
imp-add-company-on-query
branch
from
906fd56 to
359d267
Compare
AnizR
force-pushed
the
imp-add-company-on-query
branch
from
359d267 to
4d3dca5
Compare
|
This PR has the |
| if (company_field := query.sudo().company_field_id) and ( | ||
| instance_companies := self.report_instance_id.query_company_ids | ||
| ): | ||
| domain = AND([domain, [(company_field.name, "in", instance_companies.ids)]]) |
There was a problem hiding this comment.
Why doing an AND with empty domain?
| return [] | ||
| domain = [] | ||
| if (company_field := query.sudo().company_field_id) and ( | ||
| instance_companies := self.report_instance_id.query_company_ids |
There was a problem hiding this comment.
I think query_company_ids cannot be empty. And if it was, it would be surprising if the company field on the query was ignored. So may be we could simply assert self.report_instance_id.query_company_ids if company_field_id is set.
| company_field_id = fields.Many2one( | ||
| comodel_name="ir.model.fields", | ||
| ondelete="set null", | ||
| domain="[('model_id', '=', model_id)]", |
There was a problem hiding this comment.
This domain seems correct, but I wonder why it is not on the date_field above.
Description
Adds the possibility to specify a company field on queries.
This field will be used to filter records that are on the company of the instance report (using 'query_company_ids')