Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] mgmtsystem_audit #561

Closed
wants to merge 7 commits into from
Closed

[17.0] [MIG] mgmtsystem_audit #561

wants to merge 7 commits into from

Conversation

m1k3lm
Copy link
Member

@m1k3lm m1k3lm commented Dec 21, 2023

/ocabot migration mgmtsystem_audit

@mymage
Copy link
Member

mymage commented Apr 21, 2024

@m1k3lm please re-push to check test now

@m1k3lm
Copy link
Member Author

m1k3lm commented Apr 21, 2024

@mymage Done!

@mymage
Copy link
Member

mymage commented Apr 22, 2024

@mymage Done!

Thanks, it looks good but please, as I sed on the issue #554 and indicate here https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0, do a PR for each single module.
It is a bit boring but it contributes to manage code better.
Thanks!

Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have only files for the mgmtsystem_audit module

@max3903 max3903 added this to the 17.0 milestone May 19, 2024
@max3903
Copy link
Member

max3903 commented May 19, 2024

/ocabot migration mgmtsystem_audit

@mymage
Copy link
Member

mymage commented May 21, 2024

Hi @m1k3lm, the repo was fixed (see #585).
Then I think you have to update your code before do the single PR.
Since I think the code for each module is good, if you want I can help you doing PRs for specific modules using your code: let me know which one.
Thanks!

@m1k3lm
Copy link
Member Author

m1k3lm commented May 21, 2024

@mymage created separate PR for mgmtsystem_action #589 and mgmtsystem_audit #590

@mymage
Copy link
Member

mymage commented May 22, 2024

@mymage created separate PR for mgmtsystem_action #589 and mgmtsystem_audit #590

@m1k3lm Thanks: remembe to indicate it on #554

@m1k3lm m1k3lm deleted the 17.0 branch May 31, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants