Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] [MIG] mgmtsystem nonconformity hr #326

Merged
merged 3 commits into from
Jun 23, 2020
Merged

[13.0] [MIG] mgmtsystem nonconformity hr #326

merged 3 commits into from
Jun 23, 2020

Conversation

mymage
Copy link
Member

@mymage mymage commented Apr 5, 2020

No description provided.

@mymage mymage force-pushed the 13.0-mig-mgmtsystem_nonconformity_hr branch 6 times, most recently from 5b40d06 to 785a6bf Compare April 5, 2020 17:34
@mymage mymage changed the title [WIP] [13.0] [MIG] mgmtsystem nonconformity hr [13.0] [MIG] mgmtsystem nonconformity hr Apr 5, 2020
@mymage
Copy link
Member Author

mymage commented Jun 3, 2020

@ivantodorovich Ping for a fast review (migration) :-)

@ivantodorovich
Copy link
Contributor

same comments than 12.0 :)

@mymage mymage force-pushed the 13.0-mig-mgmtsystem_nonconformity_hr branch from 785a6bf to 2dd6d43 Compare June 3, 2020 13:19
@mymage
Copy link
Member Author

mymage commented Jun 3, 2020

@ivantodorovich I don't think I can do something with travis error.

@ivantodorovich
Copy link
Contributor

ivantodorovich commented Jun 3, 2020 •
edited
Loading

Have you installed pre-commit in your local clone?
https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97

This is what travis is complaining for:
mgmtsystem_audit/models/mgmtsystem_audit.py:163:13: E741 ambiguous variable name 'l

@mymage
Copy link
Member Author

mymage commented Jun 3, 2020

Sorry I don't understand. I don't touch mgmtsystem_audit. I have to fix it? On my branch?

@ivantodorovich
Copy link
Contributor

hmmm 🤔 weird.

Can you rebase on OCA:13.0?

@mymage
Copy link
Member Author

mymage commented Jun 3, 2020

Ok, but I need help, so wait a bit.

@mymage mymage force-pushed the 13.0-mig-mgmtsystem_nonconformity_hr branch 2 times, most recently from 741f087 to a0ac477 Compare June 3, 2020 17:45
@mymage
Copy link
Member Author

mymage commented Jun 3, 2020

@ivantodorovich I did it but nothing changes. Suggestions?

@ivantodorovich
Copy link
Contributor

Can you try fixing mgmtsystem_audit/models/mgmtsystem_audit.py:163:13: E741 ambiguous variable name 'l' in a separate commit?

@mymage
Copy link
Member Author

mymage commented Jun 4, 2020 •
edited
Loading

Can you try fixing mgmtsystem_audit/models/mgmtsystem_audit.py:163:13: E741 ambiguous variable name 'l' in a separate commit?

Ok
@ivantodorovich now all goes well

@mymage mymage mentioned this pull request Jun 4, 2020
Merged
@mymage mymage force-pushed the 13.0-mig-mgmtsystem_nonconformity_hr branch from a0ac477 to 9112389 Compare June 4, 2020 10:58
@mymage mymage mentioned this pull request Jun 17, 2020
Merged
mamcode
mamcode approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamcode
Copy link
Member

mamcode commented Jun 22, 2020

@mymage Please report this PR in the issue #262

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@mymage mymage mentioned this pull request Jun 23, 2020
Open
21 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-326-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 42c75ec into OCA:13.0 Jun 23, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e20518. Thanks a lot for contributing to OCA. ❤️

@mymage mymage deleted the 13.0-mig-mgmtsystem_nonconformity_hr branch December 17, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@mamcode mamcode mamcode approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mymage @ivantodorovich @mamcode @OCA-git-bot @oca-travis