Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_nl_tax_statement: don't break when writing list of ids on x2many #419

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[14.0][FIX] l10n_nl_tax_statement: don't break when writing list of ids on x2many #419

merged 1 commit into from
Oct 1, 2024

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jul 24, 2024

No description provided.

@Stephanvandenberg
Copy link

Tested on a test instance and this PR works

Stephanvandenberg
Stephanvandenberg approved these changes Aug 12, 2024
View reviewed changes
Copy link

@Stephanvandenberg Stephanvandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a test instance and the proposed changes work.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor

bosd commented Oct 1, 2024

@gjotten Can you please merge?

@gjotten
Copy link
Contributor

gjotten commented Oct 1, 2024

@NL66278 please merge

NL66278
NL66278 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Contributor

NL66278 commented Oct 1, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-419-by-NL66278-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2024
@OCA-git-bot
Merge PR #419 into 14.0
ec63bd1 
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-419-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@NL66278
Copy link
Contributor

NL66278 commented Oct 1, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-419-by-NL66278-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d83c81f into OCA:14.0 Oct 1, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f7cd44f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephanvandenberg Stephanvandenberg Stephanvandenberg approved these changes

@NL66278 NL66278 NL66278 approved these changes

@thomaspaulb thomaspaulb thomaspaulb approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hbrunn @Stephanvandenberg @OCA-git-bot @bosd @gjotten @NL66278 @thomaspaulb