[17.0][FIX] account_payment_order: add missing company currency field on payment line #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheledic
force-pushed
the
17.0_fix_missing_company_currency_field
branch
from
af799fd
to
f3cc019
Compare
micheledic
changed the title
|
Thanks @micheledic |
CarlosRoca13
approved these changes
Nov 22, 2024
sergio-teruel
approved these changes
Nov 22, 2024
carlosdauden
approved these changes
Nov 22, 2024
pedrobaeza
changed the title
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8db0718. Thanks a lot for contributing to OCA. ❤️ |
| @@ -88,6 +88,7 @@ | |||
| <field name="amount_currency" string="Amount" /> | |||
| <field name="currency_id" invisible="1" /> | |||
| <field name="name" optional="show" /> | |||
| <field name="company_currency_id" invisible="1" /> | |||
There was a problem hiding this comment.
I think that in the tree view, it should use the column_invisible attribute instead of invisible.
There was a problem hiding this comment.
Agh, true. @micheledic can you please do a PR fixing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1379