Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] account_payment_partner: Fix tests compatibility (hr_expense + partner_multi_company) #1377

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[17.0][FIX] account_payment_partner: Fix tests compatibility (hr_expense + partner_multi_company) #1377

merged 1 commit into from
Nov 20, 2024

Conversation

victoralmau
Copy link
Member

FWP from 16.0: #1376

Fix tests compatibility (hr_expense + partner_multi_company)

If we have both modules installed we will get the following error in the tests.

Incompatible companies on records:
- "OdooBot, Pieter Parter's Farm" belongs to company 'Company 2' and 'Supplier Payment Mode' (supplier_payment_mode_id: 'Credit Transfer to Suppliers') belongs to another company.
- "OdooBot, Pieter Parter's Farm" belongs to company 'Company 2' and 'Customer Payment Mode' (customer_payment_mode_id: 'Inbound Credit Trf Société Générale') belongs to another company.

@Tecnativa

@pedrobaeza pedrobaeza added this to the 17.0 milestone Nov 20, 2024
pedrobaeza
pedrobaeza approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking the fw-port test patching

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1377-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 27e14ad into OCA:17.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b61afea. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-fix-account_payment_partner-test-compatibility branch November 20, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@victoralmau @OCA-git-bot @pedrobaeza