Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FW] [16.0][IMP] bank-payment : test performance improvement #1351

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Sep 19, 2024

Port of #1350 from 16.0 to 17.0.

Commits related to account_payment_order_return are not included as this module is not ported on 17.0.

- Include context keys for avoiding mail operations overhead.
@sebalix sebalix marked this pull request as ready for review September 19, 2024 08:35
- Switch to setUpClass for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
- Switch to setUpClass (if needed) for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
- Include context keys for avoiding mail operations overhead.
- Create setUpClass method
- Switch to setUpClass (if needed) for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
- Include context keys for avoiding mail operations overhead.
- Create setUpClass method
- Include context keys for avoiding mail operations overhead.
@sebalix sebalix force-pushed the oca-port-16.0-to-17.0-pr-1350 branch from 6964858 to a499fb8 Compare September 19, 2024 08:46
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this versions, it's possible to inherit from a base test class including that context, but let's fast-track it as is as a good base:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1351-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4147854 into OCA:17.0 Sep 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dba499b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants