[16.0][MIG] account_move_name_sequence: Migration to 16.0 #1510

RodrigoBM · 2022-11-28T09:53:17Z

Add fix return sequence names do not add a space between name and returns

And add fix comment in issue #1465

And add fix comment in issue #1501 and comment #1510 (comment)

This module restores the good old behavior where journal entry numbers were generated from a sequence configured on the journal.

Add post-install script to create a sequence for all existing journals Update README accordingly

…ge lines data based on current moves

…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged

…if it is empty

After remove required=True for journal.sequence_id field it is possible to post an invoice with misconfigured journal with empty sequence So, this constraint will raise an error for this kind of cases since that using '/' could raise the unique constraint for all other moves

The required flag was wrong for sequence_id and refund_sequence_id So, it was not possible to store any change in journal for journal different to sale and purchase

…nd_of_seq_chain

…efix In case you want name your invoice YYYY-MM-SEQ (ie: 2022-07-00001) where: * YYYY: is the account move year * MM: is the account move month * SEQ: is a numerical sequence that is continue along the fiscal year assuming fiscal year is over two years (ie: from july to june next year) Before this commit the sequence prefix use now() to be compute but the range is selected with the account move date. This commit make consistency computing prefix with the account move date as well. So account move manage the first janunary for the last day of the previous year will properly use the account move date. Co-authored-by: Alexis de Lattre <[email protected]>

rafaelbn · 2022-11-30T16:50:45Z

/ocabot migration account_move_name_sequence

moylop260 · 2022-12-01T19:07:23Z

For v16.0 the new PR is fixing almost concurrency issues:

[FIX] account: unique constraint in sequence mixin odoo/odoo#104606

The README of account_move_name_sequence module for v16.0 could be deprecated

I mean, account_move_name_sequence could be good for v16.0 only if you like to allow gaps

It was asked (without answer) in the original PR:

[FIX] account: unique constraint in sequence mixin odoo/odoo#104606 (comment)

e.g. we have v11.0 instances with custom modules migrated to v14.0 failing with the following case of use:

Subscriptions

Create invoice and post
Create payment and post
Reconcile

Shop

Create Sale Order
Create payment and post
Create invoice and post
Reconcile

(This case was considered in test_sequence_concurrency_95_pay2inv_inv2pay from odoo/odoo#104647)

It could be fixed if you allow gaps for the journal of these kinds of payments

Even if the bottleneck was already fixed in v16.0

you don't have the allow-gaps option anymore, so, the module account_move_name_sequence could be helpful for these cases

So, the README of account_move_name_sequence needs to be rewrite

alexis-via · 2022-12-01T23:34:57Z

Thanks for this migration to v16. I'm testing your PR and it fails in the following scenario:

create a supplier invoice and confirm it. Keep it as unpaid.
click on "Add credit note". Keep default params of the wizard and click on "Reverse"
=> you get a draft supplier refund
Click on "Confirm". Get you this error:

The operation cannot be completed: A move can not be posted with name "/" or empty value
Check the journal sequence, please

The bug doesn't happen when the supplier refund is created manually from scratch.

RodrigoBM · 2022-12-02T12:04:24Z

Hi @alexis-via

Yea, its error its same this issue #1501 for v14 and v15.

I put de fix #1514 but this not working in v16.

I have added another fix that does solve this case and I have added a test.

alexis-via · 2022-12-06T10:37:45Z

The problem is fixed, thank you!
I noticed this warning when you start odoo:

odoo.api.create: The model odoo.addons.account_move_name_sequence.models.account_journal is not overriding the create method in batch

andreampiovesana

LGTM
functional test ok

…space between name and returns.

…ence true if value not get in vals

…supplier_reference method same issue OCA#1501 this fix not working for v16 OCA#1514

RodrigoBM · 2022-12-08T10:47:07Z

Hi @alexis-via,

I have checked the warning, the problem is that account.journal in V16 uses @api.model_create_multi for the create method.

I have added the changes to work with this @api.model_create_multi for the create method.

Regards

marcelofrare

runboat is ok

moylop260 · 2022-12-08T21:41:57Z

I think we could make the changes in the readme post-migration PR

/ocabot merge nobump

OCA-git-bot · 2022-12-08T21:42:05Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1510-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2022-12-08T21:48:05Z

Congratulations, your PR was merged at 146c448. Thanks a lot for contributing to OCA. ❤️

alexis-via and others added 30 commits November 22, 2022 14:36

Add module account_move_name_sequence

42def7f

This module restores the good old behavior where journal entry numbers were generated from a sequence configured on the journal.

sequence is now required on journals

4aeaa9c

Add post-install script to create a sequence for all existing journals Update README accordingly

[REF] account_move_name_sequence: Add number_next_actual and date ran…

d1d6874

…ge lines data based on current moves

[FIX] ir_sequence: Fix creating date_range_seq with range_month and r…

87f2818

…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged

[REF] account_move_name_sequence: Discard journals already configured

52cbe64

[UPD] Update account_move_name_sequence.pot

9ac1af9

[UPD] README.rst

7e0350a

[ADD] icon.png

d45cda0

[FIX] account_move_name_sequence: Fix sequence domain to assign only …

1a2b072

…if it is empty

account_move_name_sequence 14.0.1.0.1

5add0a4

[UPD] Update account_move_name_sequence.pot

6caddd3

account_move_name_sequence 14.0.1.1.0

caf256d

[FIX] account_move_name_sequence: Fix required journal fields in view

476532f

The required flag was wrong for sequence_id and refund_sequence_id So, it was not possible to store any change in journal for journal different to sale and purchase

account_move_name_sequence 14.0.1.2.0

d9df97e

[REF] account_move_name_sequence: Add maintainers to myself

3cd3182

[UPD] README.rst

3a698a9

[REF] account_move_name_sequence: Adding concurrency cases in README

f90d1bf

[UPD] README.rst

4a0c64d

account_move_name_sequence 14.0.1.2.1

cdc7934

[REF] account_move_name_sequence: Use Odoo native methods + Typos

1653cc4

[UPD] README.rst

7f1c4ba

account_move_name_sequence 14.0.1.2.2

3a1b342

[MIG] account_move_name_sequence: Migration to 15.0

a800db0

[FIX] account_move_name_sequence: Exclude no_gap sequences from _is_e…

1987242

…nd_of_seq_chain

[UPD] Update account_move_name_sequence.pot

ad207c5

[UPD] README.rst

b70341d

account_move_name_sequence 15.0.1.1.0

d07e939

[IMP] : pre-commit stuff

a07eeda

rafaelbn added the needs review label Nov 30, 2022

rafaelbn requested a review from moylop260 November 30, 2022 16:51

OCA-git-bot added this to the 16.0 milestone Nov 30, 2022

moylop260 mentioned this pull request Dec 1, 2022

16.0 - [REF] account: Adding unittests for concurrency issues in account_move sequences odoo/odoo#104647

Closed

RodrigoBM force-pushed the 16.0-mig-account_move_name_sequence branch from 105326e to dc30382 Compare December 2, 2022 11:59

RodrigoBM force-pushed the 16.0-mig-account_move_name_sequence branch 2 times, most recently from 4971302 to ad51021 Compare December 2, 2022 15:18

RodrigoBM changed the title ~~[16.0][MIG] account_move_name_sequence~~ [16.0][MIG] account_move_name_sequence: Migration to 16.0 Dec 4, 2022

andreampiovesana approved these changes Dec 7, 2022

View reviewed changes

RodrigoBM added 4 commits December 8, 2022 11:35

[MIG] account_move_name_sequence: Migration to 16.0

86eed6c

[FIX] account_move_name_sequence: return sequence names do not add a …

2d5f794

…space between name and returns.

[FIX] account_move_name_sequence: issue OCA#1465 vals get refund_sequ…

346eb9d

…ence true if value not get in vals

[FIX] account_move_name_sequence: call flush before _fetch_duplicate_…

ab8e59d

…supplier_reference method same issue OCA#1501 this fix not working for v16 OCA#1514

RodrigoBM force-pushed the 16.0-mig-account_move_name_sequence branch from ad51021 to ab8e59d Compare December 8, 2022 10:37

marcelofrare approved these changes Dec 8, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 8, 2022

OCA-git-bot added the bot is merging ⏳ label Dec 8, 2022

OCA-git-bot merged commit 3bfe850 into OCA:16.0 Dec 8, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 8, 2022

RodrigoBM deleted the 16.0-mig-account_move_name_sequence branch December 9, 2022 12:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_move_name_sequence: Migration to 16.0 #1510

[16.0][MIG] account_move_name_sequence: Migration to 16.0 #1510

RodrigoBM commented Nov 28, 2022 •

edited

Loading

rafaelbn commented Nov 30, 2022

moylop260 commented Dec 1, 2022 •

edited

Loading

alexis-via commented Dec 1, 2022

RodrigoBM commented Dec 2, 2022

alexis-via commented Dec 6, 2022

andreampiovesana left a comment

RodrigoBM commented Dec 8, 2022

marcelofrare left a comment

moylop260 commented Dec 8, 2022

OCA-git-bot commented Dec 8, 2022

OCA-git-bot commented Dec 8, 2022

[16.0][MIG] account_move_name_sequence: Migration to 16.0 #1510

[16.0][MIG] account_move_name_sequence: Migration to 16.0 #1510

Conversation

RodrigoBM commented Nov 28, 2022 • edited Loading

rafaelbn commented Nov 30, 2022

moylop260 commented Dec 1, 2022 • edited Loading

alexis-via commented Dec 1, 2022

RodrigoBM commented Dec 2, 2022

alexis-via commented Dec 6, 2022

andreampiovesana left a comment

Choose a reason for hiding this comment

RodrigoBM commented Dec 8, 2022

marcelofrare left a comment

Choose a reason for hiding this comment

moylop260 commented Dec 8, 2022

OCA-git-bot commented Dec 8, 2022

OCA-git-bot commented Dec 8, 2022

RodrigoBM commented Nov 28, 2022 •

edited

Loading

moylop260 commented Dec 1, 2022 •

edited

Loading