[16.0][FIX] openupgrade_framework : end-migration scripts are forced …

[metaminux]

…to run at install too

Fixes #4106

[OCA-git-bot]

Hi @hbrunn, @StefanRijnhart, @legalsylvain,
some modules you are maintaining are being modified, check this out!

[hbrunn]

thanks, the CI errors are unrelated.

do we have any core modules where this is the case in v16? If so, a test for that would be great.

[metaminux]

@hbrunn There is no end-migration script for v16 in openupgrade_scripts, but there are 2 files in native Odoo CE :

• https://github.com/odoo/odoo/blob/74b555766ae6e63efe70f07b3ebcbaa94050f183/addons/l10n_lu/migrations/2.1/end-migrate_update_taxes.py
• https://github.com/odoo/odoo/blob/74b555766ae6e63efe70f07b3ebcbaa94050f183/addons/l10n_ch/migrations/11.1/end-migrate_update_taxes.py#L4

Can we use those files to run a test ?

[hbrunn]

never tried it, but I think it could just work to drop a folder with the module name and correct version into https://github.com/OCA/OpenUpgrade/tree/16.0/openupgrade_scripts/scripts, cf https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_framework/odoo_patch/odoo/tests/loader.py#L30

Edit: ah wait, those are localization modules and those aren't installed in the test database we use. And it must be a newly pulled module anyways. How about adding an end migration script for ie spreadsheet (that's new in v16 and pulled during the migration), check for environment variable OPENUPGRADE_TESTS and if that's set, ie set some config parameter as marker that you can check for in the test?

[metaminux]

Hello @hbrunn

Instead of creating an end-migration script in the "production" tree of openupgrade_scripts, I'd like to copy such script during the tests using data.py file... but I'm struggling to get a right path from the Odoo shell.

It seems I can't get the value of GITHUB_WORKSPACE... any advice ?

[hbrunn]

just $GITHUB_WORKSPACE is empty? Not sure however what I think of this approach, anyone else an opinion?

Just to be clear, I don't insist on the test, just thought it was nice

[pedrobaeza]

No idea, sorry.

[hbrunn]

so... do we go ahead and merge this?

[pedrobaeza]

OK, please rebase to check the CI.

[metaminux]

H everyone,

CI is not OK after rebase, I'll convert this PR to draft for the moment because it seems to me that some others changes in the way odoo is loading modules are preventing post-* and end-* migration scripts to execute for newly installed ones...

[metaminux]

Hi @hbrunn Hi @pedrobaeza

Sorry for the delay... I just rebased and had to fix some typo for pre-commit to run OK.

I think we can go ahead...
Tests are using the end migration script for spreadsheet which is newly installed. See https://github.com/OCA/OpenUpgrade/actions/runs/12905959373/job/35986260407?pr=4107#step:16:18575

[MiquelRForgeFlow]

Could you rebase correctly? I see merge branch commits there. I think you should have here only two commits (the pre-commit commit can be fused with the commit that adds tests)

[metaminux]

@MiquelRForgeFlow Rebase correctly done, thanks

end migration script for newly installed spreadsheet module runs : https://github.com/OCA/OpenUpgrade/actions/runs/12910128466/job/35999439017?pr=4107#step:16:18582