Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2 #3

Merged
merged 103 commits into from
Oct 9, 2024
Merged

Issue 2 #3

merged 103 commits into from
Oct 9, 2024

Conversation

Ateyu
Copy link
Contributor

@Ateyu Ateyu commented Aug 22, 2024 •
edited
Loading

Feat #2

The paper is implemented.
Syntax Highlighting, Error highlighting and quick removal implemented.
Auto completion works for features and operators.

Ateyu added 19 commits August 7, 2024 15:21
@Ateyu
First draft
5b0eb6d
@Ateyu
Grammar covers synatax. Not tested yet.
3729c2f
@Ateyu
Add: First draft of the editor. Open and writing works.
8910e09
@Ateyu
add: Button to save the file
865e293
@Ateyu
add: update structure
bf8a4d4 
add: adding bundle to include EditorView
add: package-lock.json
add: highlight.js to have a simple structure
add: adding completions.js to autocomplete
feat: old libs got removed
feat: opening loads in the state now
feat: basic css applied
feat: grammar.grammar slightly changed because lezer-generator and lezer grammar allow different token
@Ateyu
fix: file saving didnt save current state
ea78945
@Ateyu
add: lit element containing the editor, load button and save button
f2a52b2
@Ateyu
feat: change body from script editor to lit component containing the …
005745c 
…editor
@Ateyu
add: adding completions export for testing. Designed to be added to l…
5902811 
…anguage
@Ateyu
feat: EditorView tested and errors spotted
2543400
@Ateyu
feat: updated
9df170b
@Ateyu
feat: main file for language package controlling language form parser…
11b3564 
… and autocompletion
@Ateyu
feat: rm unnecessary features
c621150
@Ateyu
add: update structure
60d3465
@Ateyu
feat: adding basic autocompletion to language
1f85bf9
@Ateyu
doc: adding intentions for the highlighting
2e1c02e
@Ateyu
fix: removing parser features form file to keep the editor running
1b02e4a
@Ateyu
add: adding a save and load button for the editor. Passed first tests
6840d6e
@Ateyu
feat: adding description
29e497a
h3ssto
h3ssto reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@h3ssto h3ssto left a comment •
edited by Ateyu
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright so far, not sure about the large number of *.mjs.
Features still missing:

  • Codemirror
    • Autocompletion
      • Keywords (mandatory, optional, ...)
      • Feature Names (when in constraints)
      • Boolean Operators (when in constraints)
    • Syntax Highlighting
  • General
    • Decide on surrounding js framework and wrap

package.json Outdated Show resolved Hide resolved
src/parser.terms.js Outdated Show resolved Hide resolved
@h3ssto h3ssto linked an issue Aug 23, 2024 that may be closed by this pull request
Basic Editor based on Codemirror #2
Closed
h3ssto
h3ssto reviewed Aug 23, 2024
View reviewed changes
src/editor.bundle.js Outdated Show resolved Hide resolved
@h3ssto
Copy link
Contributor

h3ssto commented Aug 28, 2024 •
edited by Ateyu
Loading

Please mark the remaining features and answer the questions above.
Missing in Grammar:

  • Force line break after mandatory, optional, or, alternative
  • In Cross-Tree Constraints: Add support for & (and) and ! (not) as well as brackets
  • Show Syntax Errors (e.g., Space in Feature Names without surrounding " ")

Ateyu and others added 27 commits September 13, 2024 01:29
@Ateyu
feat: fixed and tested with examples
57b0a43
@Ateyu
feat: doc changes for testing
4941f8f
@Ateyu
fix: changing tokes to public tokens
af55aa0
@Ateyu
feat: constraints support
e52bd6a
@Ateyu
feat: adding feature error highlighting
9df5fd3
@Ateyu
feat: adding first steps for operator syntax
317fc55
@Ateyu
fix: adjusting to bundle
b6832bc
@Ateyu
feat: adding feature.key error
d4ce8a0
@Ateyu
feat: adding counter error
464c899
@Ateyu
fix: fixing counter to allow min = max
5071649
@Ateyu
feat: adding operator error
bcea8c4
@Ateyu
feat: adding highlighting
1942e81
@Ateyu
add: adding tab size = 4
4e0dbc0
@Ateyu
fix: removing outdated functions
8181489
@Ateyu
fix: @codemirror/commands got an update and does not work like before…
1156d4a 
…. Temp fix to put commands in dependencies to enable the editor
@Ateyu
feat: duplicated key disabled
dd44211
@Ateyu
feat: duplicated feature disabled
e55e8f9
@Ateyu
feat: feature check in operation added
b23a414
@Ateyu
Issue 4 (#9)
525c560 
Feat #4 
Added tests for the parser.

---------

Co-authored-by: Tobias Heß <[email protected]>
@Ateyu
fix: Neg to BooleanNeg
03e6c38
@Ateyu
fix: remove unnecessary files
d2e6d57
@Ateyu
feat: avg, sum and len only for keys like the old editor
71235be
@Ateyu
feat: clearing precedence, restructuring and cleanup
96188f8
@Ateyu
feat: avg and sum only for numbers
ebc01dd
@Ateyu
Merge remote-tracking branch 'origin/main' into issue-2
f872aaf 
# Conflicts:
#	.github/workflows/node.js.yml
@Ateyu
fix: removing old code
cc5d9f0
@Ateyu
feat: adapting tests
ac014b0
@h3ssto h3ssto merged commit 8c22aba into main Oct 9, 2024
@h3ssto h3ssto deleted the issue-2 branch October 9, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3ssto h3ssto h3ssto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic Editor based on Codemirror
2 participants
@Ateyu @h3ssto