-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add help
target to Makefile to display the usage of all targets
#125
Conversation
WalkthroughThe Makefile has been significantly enhanced to streamline various development, testing, and deployment processes. This includes adding new targets for formatting code, updating submodules, building and testing smart contracts, deploying these contracts to the NEAR testnet, and managing Docker images for different components. Additionally, there are new targets for executing ERC20 transfers and a help command to provide users with information on available commands. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Makefile
participant NEAR Testnet
participant Docker
participant CDK Node
Developer->>Makefile: run build-contracts
Makefile->>Makefile: Create blob store contract
Developer->>Makefile: run test-contracts
Makefile->>Makefile: Create blob store contract and run tests
Developer->>Makefile: run deploy-contracts
Makefile->>NEAR Testnet: Deploy near-da-blob-store contract
Developer->>Makefile: run da-rpc-docker
Makefile->>Docker: Build Docker image for da-rpc
Developer->>Makefile: run cdk-devnet-up
Makefile->>CDK Node: Start cdk-validium-node development network
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Makefile (2 hunks)
Additional comments not posted (14)
Makefile (14)
4-6
: LGTM!The
format
target correctly formats the code usingtaplo
andcargo fmt
.
9-11
: LGTM!The
submodules
target correctly updates submodules.
18-20
: LGTM!The
build-contracts
target correctly builds thenear-da-blob-store
contract.
22-24
: LGTM!The
test-contracts
target correctly builds thenear-da-blob-store
contract and runs tests.
27-29
: LGTM!The
deploy-contracts
target correctly deploys thenear-da-blob-store
contract to the NEAR testnet.
35-37
: LGTM!The
da-rpc-docker
target correctly builds the Docker image.
40-45
: LGTM!The
da-rpc-sys-unix
target correctly copies the compiledda-rpc
library from the Docker image to the local filesystem.
48-54
: LGTM!The
cdk-images
target correctly pulls and tags thecdk-validium-contracts
andcdk-validium-node
Docker images.
56-58
: LGTM!The
cdk-devnet-up
target correctly starts thecdk-validium-node
development network and explorer.
61-63
: LGTM!The
cdk-devnet-down
target correctly stops thecdk-validium-node
development network.
66-68
: LGTM!The
cdk-node
target correctly builds thecdk-validium-node
.
71-73
: LGTM!The
send-cdk-transfers
target correctly runs the ERC20 transfers script.
76-78
: LGTM!The
cdk-devnet-redeploy-test
target correctly builds and starts thecdk-validium-node
development network, then tests the ERC20 transfers script.
80-84
: LGTM!The
help
target correctly displays the help message.
Similar to near/nearcore pulls#11784
The
help
target will be helpful for new developers begin to contribute for this project.This change is
Summary by CodeRabbit