feat: basic blob-registry contract

[palozano]

New blob-registry contract.

---

This change is 

[dndll]

Looks great, just needs some small changes

[dndll]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @palozano)

[dndll]

Reviewed 1 of 7 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @palozano)

---

contracts/blob-registry/src/lib.rs line 102 at r1 (raw file):

Previously, palozano (Lozano) wrote…

And should we do something with the vector of transaction IDs (I assume they are strings)? Store them or do nothing for now?

For now, we do nothing. Eventually we will have onchain priority queue

---

contracts/blob-registry/src/lib.rs line 110 at r1 (raw file):

Previously, palozano (Lozano) wrote…

update_owner() is only checking new != old, so I think we still need require_owner() to check that the only one calling this method is the owner, right?

I see, is it still asserting one yocto too? Or has that changed. IIRC jacob asserted one yocto on most sdkctl calls

---

contracts/blob-registry/src/lib.rs line 39 at r3 (raw file):

type Priority = u32;
type Maintainer = Vec<u8>;
type TransactionId = String;

This is a problem if it's a string. At best, I'd be happy to take 32-byte arrays if the crypto hash isn't available. It's even better to use a custom serializer/deserializer such that they are hex-encoded by Serde. Check NEARX or libs (don't use a lib since they're usually bloated and near contracts can now only be 1.5mb.)

---

contracts/blob-registry/src/lib.rs line 117 at r3 (raw file):

            env::panic_str(ERR_NAMESPACE_EXISTS);
        } else {
            // when the deposit is enough

gud

[palozano]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dndll)

---

contracts/blob-registry/src/lib.rs line 102 at r1 (raw file):

Previously, dndll (Don) wrote…

For now, we do nothing. Eventually we will have onchain priority queue

Done.

---

contracts/blob-registry/src/lib.rs line 110 at r1 (raw file):

Previously, dndll (Don) wrote…

I see, is it still asserting one yocto too? Or has that changed. IIRC jacob asserted one yocto on most sdkctl calls

As far as I've seen, there's no assertion for one yocto. This is the implementation of the method.

Code snippet:

fn update_owner(&mut self, new: Option<AccountId>) {
    let owner = Self::slot_owner();
    let old = owner.read();
    if old != new {
        OwnerEvent::Transfer {
            old,
            new: new.clone(),
        }
        .emit();
        self.update_owner_unchecked(new);
    }
}

---

contracts/blob-registry/src/lib.rs line 39 at r3 (raw file):

Previously, dndll (Don) wrote…

This is a problem if it's a string. At best, I'd be happy to take 32-byte arrays if the crypto hash isn't available. It's even better to use a custom serializer/deserializer such that they are hex-encoded by Serde. Check NEARX or libs (don't use a lib since they're usually bloated and near contracts can now only be 1.5mb.)

I will go with the custom de/serializer

---

contracts/blob-registry/src/lib.rs line 117 at r3 (raw file):

Previously, dndll (Don) wrote…

gud

Done.

[dndll]

Reviewed 9 of 9 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @palozano)

[dndll]

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @palozano)