Localized artifacts now contain Authenticode signed assemblies #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jeffkl
previously approved these changes
Nov 27, 2024
jeffkl
approved these changes
Nov 27, 2024
jgonz120
approved these changes
Nov 27, 2024
Nigusu-Allehu
approved these changes
Nov 27, 2024
zivkan
reviewed
Nov 28, 2024
| @@ -24,9 +24,11 @@ Unfortunately, NuGet.Client does not use OneLocBuild, and any resource comments | |||
| Although the steps below are for the dev branch, the process is similar for release branches. | |||
|
|
|||
| 1. A PR merges into the dev branch. | |||
| 1. A NuGet.Client build generates a `localizationArtifacts` artifact. This artifact contains newly built (but unsigned) assemblies and .lcg files. The .lcg files contain information extracted from .resx files and are the primary input for later localization. | |||
| 1. A NuGet.Client build generates a `localizationArtifacts` artifact. This artifact contains newly built Authenticode-signed assemblies [(see PR#6170)][12]) containing English resources and .lcg files. | |||
There was a problem hiding this comment.
Suggested change
| 1. A NuGet.Client build generates a `localizationArtifacts` artifact. This artifact contains newly built Authenticode-signed assemblies [(see PR#6170)][12]) containing English resources and .lcg files. | |
| 1. A NuGet.Client build generates a `localizationArtifacts` artifact. This artifact contains newly built assemblies containing English resources and .lcg files. |
If someone needs to investigate the loc process in a year or more from now, I'm not sure why the PR would be interesting to call out specifically. In fact, the fact that it's signed or not also doesn't seem important to me.
The loc team's tools don't have a requirement about signed or unsigned assemblies.
| 1. The localization team grabs the `localizationArtifacts` artifact from a NuGet.Client build. | ||
| 1. The localization team localizes strings and merges a ["LEGO" PR][5] with localized strings (in .lcl files). | ||
| 1. The localization team localizes strings. | ||
| The signed assemblies are used to validate the exported .lcl won't break the build before the team merges a ["LEGO" PR][5] with localized strings (in .lcl files). |
There was a problem hiding this comment.
Suggested change
| The signed assemblies are used to validate the exported .lcl won't break the build before the team merges a ["LEGO" PR][5] with localized strings (in .lcl files). | |
| The assemblies are used to validate the exported .lcl won't break the build before the team merges a ["LEGO" PR][5] with localized strings (in .lcl files). |
| [11]: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/20709/MicroBuild-Localization | ||
| [12]: https://github.com/NuGet/NuGet.Client/pull/6170 |
There was a problem hiding this comment.
Similar to another comment, it's not clear to me why someone reading these docs would be more interested in this pull request than any other pull request that modified build/loc.proj or the build yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
Documentation update for #6170
PR Checklist