Add new test cases for Transitive Package into NuGet.Client-VSDaily Tests pipeline

[CiciLi1]

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/3070

Description

Add the below three new test cases about the "Transitive Package" feature to the NuGet.Client-VSDaily Tests pipeline.

Search a top-level package in "Installed" tab
Install a top level package which have a transitive package
Verify uninstalling a top-level package will uninstall the transitive package automatically

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

[donnie-msft]

Suggested change

using Microsoft.TeamFoundation.Common;

[CiciLi1]

The IsNullOrEmpty() method need this using Microsoft.TeamFoundation.Common;

[donnie-msft]

Ok. I believe this is a LINQ extension method. Could you try replacing it with using System.Linq; ?

By the way, this happens to me often as well. IntelliSense chooses the TeamFoundation namespace for some reason, but I think using Linq directly is better.

[CiciLi1]

The namespace "using System.Linq;" has been reference in this file #line 7, but the using Microsoft.TeamFoundation.Common; still been prompted for a reference when using the IsNullOrEmpty() method.

[nkolev92]

Just write your method.
Let's not take dependencies in "generic" apis from packages not meant to deliver generic code.

Can that value ever be null even? An empty check should be enough.

[donnie-msft]

Rather than write a method, we often use FluentAssertions: collection.Should().BeNullOrEmpty();
See https://fluentassertions.com/collections/

[CiciLi1]

Thanks to everyone's suggestions, we have removed the namwspace and updated the assertion method with collection.Should().BeNullOrEmpty();, could you please help to review it, thanks.

[donnie-msft]

I'm not clear on why this assertion is made both before the SearchPackageFromUI call and after the call. Is there a common bug where installing shows the TopLevel package but a following Search does not show that TopLevel package?

Should uiwindow.AssertPackageNameAndType(transitivePackageName, NuGet.VisualStudio.PackageLevel.Transitive); also be asserted after the Act?

[CiciLi1]

Thanks for your review. 😊
First question: We call these assertions before SearchPackageFromUI to make sure that the package is installed successfully with the top-level package under the “top-level packages” node and the transitive packages under the “transitive packages” node.

The second question: the test case is search for packages under the “top-level packages” node, so after searching for top-level packages, only the top-level packages are displayed. So, we didn't add assert transitive.

[donnie-msft]

Makes sense. I believe also since the search is for an exact match package ID, there should be no transitive shown.

It may be worth considering a test where you search "Contoso" and find both a top-level Contoso.A and a transitive Contoso.C, or similar.

[CiciLi1]

Thanks for your suggestion, we have added this test case SearchTopLevelAndTransitivePackagePublicFieldInInstalledTabFromUI to this PR, please help to review it, thanks again.