Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringFilterKind exhaustive filters #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s0ssh
Copy link

@s0ssh s0ssh commented Nov 24, 2024

Previously, the steamworks::StringFilterKind enum lacked the exhaustive filter options exposed by the Steamworks API, only exposing k_ELobbyComparisonEqual and k_ELobbyComparisonNotEqual, quite confusingly, as StringFilterKind::Include and StringFilterKind::Exclude respectively. I have patched these into the enum.

...
match filter {
    StringFilterKind::EqualToOrLessThan=> sys::ELobbyComparison::k_ELobbyComparisonEqualToOrLessThan,
    StringFilterKind::LessThan=> sys::ELobbyComparison::k_ELobbyComparisonLessThan,
    StringFilterKind::Equal=> sys::ELobbyComparison::k_ELobbyComparisonEqual,
    StringFilterKind::GreaterThan=> sys::ELobbyComparison::k_ELobbyComparisonGreaterThan,
    StringFilterKind::EqualToOrGreaterThan=> sys::ELobbyComparison::k_ELobbyComparisonEqualToOrGreaterThan,
    StringFilterKind::NotEqual=> sys::ELobbyComparison::k_ELobbyComparisonNotEqual,
}
...

This PR resolves #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringFilterKind enum is missing exhaustive filters
1 participant