fix: improve phpinsights

lang/en/about.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'About the SiteBoss CMS',
     'version' => 'Version',

lang/en/auth.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
 
     /*

lang/en/page.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 // TODO: update values to use proper naming convention
 return [
     'title' => 'Pages',

lang/en/passwords.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
 
     /*

lang/en/preferences.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'User preferences',
     'subtitle' => 'Here you can change your preferences',

lang/en/response.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'unauth' => 'Unauthorized user',
     'tokenexp' => 'Token expired',

lang/en/support.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'Support',
     'breadcrumb' => 'Support',

lang/en/ui.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'save' => 'Save',
     'save_no_redirect' => 'Save and stay on this page',

lang/en/validation.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
 
     /*

lang/nl/about.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'Over SiteBoss CMS',
     'version' => 'Versie',

lang/nl/auth.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     /*
     |--------------------------------------------------------------------------

lang/nl/page.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => "Pagina's",
     'edit' => 'Wijzig pagina',

lang/nl/passwords.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
 
     /*

lang/nl/preferences.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'Gebruikersvoorkeuren',
     'subtitle' => 'Wijzig hier je voorkeuren',

lang/nl/redirects.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'Doorverwijzingen',
     'widget_title' => 'Overzicht van alle doorverwijzingen',

lang/nl/response.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'unauth' => 'Gebruiker onbevoegd',
     'tokenexp' => 'Token verlopen',

lang/nl/support.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'title' => 'Support',
     'breadcrumb' => 'Support',

lang/nl/ui.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'save' => 'Opslaan',
     'save_no_redirect' => 'Opslaan en op deze pagina blijven',

lang/nl/validation.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
 
     /*

routes/api.php

@@ -27,6 +27,7 @@
 | is assigned the "api" middleware group. Enjoy building your API!
 |
 */
+
 Route::prefix(config('siteboss.api_prefix'))->group(function () {
 
     // Routes account management
@@ -44,7 +45,7 @@
     Route::prefix('api')->group(function () {
 
         // Unauthenticated routes
-        Route::namespace('Forms')->group(function () {
+        Route::namespace('Forms')->group(function (): void {
             Route::post('forms/{form:id}/{langurl}', [DataController::class, 'create'])->middleware(ProtectAgainstSpam::class)->name('formbuilder.post');
             Route::get('fields/{id}', [FieldController::class, 'readOneJson']);
             // RIGHTS!!!!!
@@ -62,9 +63,9 @@
     Route::get('settings', [InfoController::class, 'settings']);
 
     // Authenticated routes
-    Route::group(['middleware' => ['auth:openid', 'api', EnsureEmailIsVerified::class]], function () {
+    Route::group(['middleware' => ['auth:openid', 'api', EnsureEmailIsVerified::class]], function (): void {
         // Language for messages (not the language used for storing data)
-        Route::group(['prefix' => '/{locale}', 'middleware' => 'set-forget-locale'], function () {
+        Route::group(['prefix' => '/{locale}', 'middleware' => 'set-forget-locale'], function (): void {
             Route::get('info', [InfoController::class, 'index']);
 
             // TODO: remove this route?
@@ -76,7 +77,7 @@
             // Form builder
             Route::middleware('role:forms')->group(__DIR__.'/cms/forms.php');
 
-            Route::prefix('app')->group(function () {
+            Route::prefix('app')->group(function (): void {
                 if (file_exists(base_path().'/routes/siteboss.php')) {
                     Route::prefix('site')->group(
                         base_path().'/routes/siteboss.php'
@@ -109,7 +110,7 @@
                 Route::get('about', [AboutController::class, 'index']);
 
                 // Support page for SiteBoss CMS
-                Route::prefix('support')->group(function () {
+                Route::prefix('support')->group(function (): void {
                     Route::get('', [SupportController::class, 'index']);
                     Route::post('', [SupportController::class, 'update']);
                 });

routes/cms/editor.php

@@ -16,18 +16,18 @@
 Route::post('table-export', [CmsEditorImportExportController::class, 'exportAllTables']);
 Route::post('template-export', [CmsEditorImportExportController::class, 'exportAllTemplates']);
 // table
-Route::prefix('table')->group(function () {
+Route::prefix('table')->group(function (): void {
     Route::get('', [CmsEditorTableController::class, 'index']);
     Route::post('', [CmsEditorTableController::class, 'create']);
 
-    Route::prefix('{table}')->group(function () {
+    Route::prefix('{table}')->group(function (): void {
         Route::get('', [CmsEditorTableController::class, 'readOne']);
         Route::post('', [CmsEditorTableController::class, 'update']);
 
         Route::put('move', [CmsEditorTableController::class, 'updatePosition']);
         Route::post('add-field', [CmsEditorTableController::class, 'addField']);
 
-        Route::prefix('{tableItem}')->group(function () {
+        Route::prefix('{tableItem}')->group(function (): void {
             Route::get('', [CmsEditorTableItemController::class, 'readOne']);
             Route::post('', [CmsEditorTableItemController::class, 'update']);
             Route::post('enabled', [CmsEditorTableItemController::class, 'enabled']);
@@ -36,46 +36,46 @@
 });
 
 // pages
-Route::prefix('page')->group(function () {
+Route::prefix('page')->group(function (): void {
     Route::get('', [CmsEditorTemplateController::class, 'index']);
     Route::post('', [CmsEditorTemplateController::class, 'create']);
 
-    Route::prefix('{table}')->group(function () {
+    Route::prefix('{table}')->group(function (): void {
         Route::get('', [CmsEditorTemplateController::class, 'readOne']);
         Route::post('', [CmsEditorTemplateController::class, 'update']);
         Route::post('import', [CmsEditorImportExportController::class, 'importTemplate']);
 
         Route::put('move', [CmsEditorTemplateController::class, 'updatePosition']);
         Route::post('add-field', [CmsEditorTemplateController::class, 'addField']);
 
-        Route::prefix('{tableItem}')->group(function () {
+        Route::prefix('{tableItem}')->group(function (): void {
             Route::get('', [CmsEditorTemplateItemController::class, 'readOne']);
             Route::post('', [CmsEditorTemplateItemController::class, 'update']);
             Route::post('enabled', [CmsEditorTemplateItemController::class, 'enabled']);
         });
     });
 });
 
-Route::prefix('menu')->group(function () {
+Route::prefix('menu')->group(function (): void {
     Route::get('', [CmsEditorMenuController::class, 'index']);
     Route::post('', [CmsEditorMenuController::class, 'addItem']);
 
     Route::put('move', [CmsEditorMenuController::class, 'updatePosition']);
 
-    Route::prefix('{menuItem}')->group(function () {
+    Route::prefix('{menuItem}')->group(function (): void {
         Route::get('', [CmsEditorMenuController::class, 'readOne']);
         Route::post('', [CmsEditorMenuController::class, 'update']);
         Route::delete('', [CmsEditorMenuController::class, 'deleteRecord']);
     });
 });
 
-Route::prefix('lang')->group(function () {
+Route::prefix('lang')->group(function (): void {
     Route::get('', [CmsEditorLangController::class, 'index']);
     Route::post('', [CmsEditorLangController::class, 'create']);
 
     Route::put('move', [CmsEditorLangController::class, 'updatePosition']);
 
-    Route::prefix('{lang:id}')->group(function () {
+    Route::prefix('{lang:id}')->group(function (): void {
         Route::get('', [CmsEditorLangController::class, 'readOne']);
         Route::post('', [CmsEditorLangController::class, 'update']);
         Route::delete('', [CmsEditorLangController::class, 'deleteRecord']);

routes/cms/forms.php

@@ -7,22 +7,22 @@
 use NotFound\Framework\Http\Controllers\Forms\FieldController;
 use NotFound\Framework\Http\Controllers\Forms\FormController;
 
-Route::namespace('Forms')->group(function () {
+Route::namespace('Forms')->group(function (): void {
     // /forms
-    Route::prefix('forms')->group(function () {
+    Route::prefix('forms')->group(function (): void {
         Route::post('', [FormController::class, 'create']);
 
         Route::get('combinations', [FormController::class, 'readAllCombinations']);
         Route::get('archive', [FormController::class, 'readAllArchive']);
 
         // /forms/categories
-        Route::prefix('categories')->group(function () {
+        Route::prefix('categories')->group(function (): void {
             Route::get('', [CategoryController::class, 'readAllBasedOnRights']);
             Route::get('{category:slug}', [FormController::class, 'readAllBasedOnCategory']);
         });
 
         // /forms/{id}
-        Route::prefix('{form:id}')->group(function () {
+        Route::prefix('{form:id}')->group(function (): void {
             Route::delete('', [FormController::class, 'delete']);
             Route::put('', [FormController::class, 'update']);
             Route::post('clone', [FormController::class, 'clone']);
@@ -31,13 +31,13 @@
             Route::get('csv', [DownloadController::class, 'downloadReport']);
 
             // /forms/{id}/settings
-            Route::prefix('settings')->group(function () {
+            Route::prefix('settings')->group(function (): void {
                 Route::get('', [FormController::class, 'getText']);
                 Route::put('', [FormController::class, 'updateText']);
             });
 
             // /forms/{id}/fields
-            Route::prefix('fields')->group(function () {
+            Route::prefix('fields')->group(function (): void {
                 Route::get('', [FieldController::class, 'readOne']);
                 Route::patch('', [FieldController::class, 'update']);
 
@@ -46,13 +46,13 @@
             });
 
             // /forms/{id}/data
-            Route::prefix('data')->group(function () {
+            Route::prefix('data')->group(function (): void {
                 Route::get('', [DataController::class, 'readOne']);
                 Route::get('all', [DataController::class, 'readOneAll']);
                 Route::get('filled', [DataController::class, 'readOneFilled']);
 
                 // /forms/{id}/data/{id}
-                Route::prefix('{recordId}')->group(function () {
+                Route::prefix('{recordId}')->group(function (): void {
                     Route::delete('', [DataController::class, 'deleteRow']);
                     Route::patch('', [DataController::class, 'updateField']);
                 });

routes/cms/forwards.php

@@ -5,12 +5,12 @@
 
 Route::get('/', [ForwardsController::class, 'getOptions']);
 
-Route::prefix('domains')->group(function () {
+Route::prefix('domains')->group(function (): void {
     Route::get('/', [ForwardsController::class, 'readAll']);
     Route::get('/{domain:id}', [ForwardsController::class, 'readOne']);
 });
 
-Route::prefix('options')->group(function () {
+Route::prefix('options')->group(function (): void {
     Route::get('/', [ForwardsController::class, 'readAll']);
     Route::get('/rules/', [ForwardsController::class, 'readAll']);
 });

routes/cms/page.php

@@ -10,7 +10,7 @@
 Route::post('create/{menu}', [MenuController::class, 'create']);
 
 // /app/page/{id}/editor/
-Route::prefix('{menu}/editor/{langSlug}')->group(function () {
+Route::prefix('{menu}/editor/{langSlug}')->group(function (): void {
     Route::get('', [PageEditorController::class, 'index']);
     Route::post('', [PageEditorController::class, 'update']);
     Route::get('{fieldInternal}', [PageItemEditorController::class, 'ajaxGet']);

routes/cms/table.php

@@ -5,18 +5,18 @@
 use NotFound\Framework\Http\Controllers\Assets\TableItemEditorController;
 use NotFound\Framework\Http\Controllers\Assets\TableOverviewController;
 
-Route::prefix('{table:url}')->group(function () {
+Route::prefix('{table:url}')->group(function (): void {
     Route::get('', [TableOverviewController::class, 'index']);
     Route::put('', [TableOverviewController::class, 'updateField']);
     Route::post('', [TableOverviewController::class, 'create']);
     Route::put('move', [TableOverviewController::class, 'updatePosition']);
 
     // /table/{slug}/{recordId}
-    Route::prefix('{recordId}')->group(function () {
+    Route::prefix('{recordId}')->group(function (): void {
         Route::delete('', [TableEditorController::class, 'deleteRecord']);
 
         // /table/{slug}/{recordId}/{lang}
-        Route::prefix('{langSlug}')->group(function () {
+        Route::prefix('{langSlug}')->group(function (): void {
             Route::get('', [TableEditorController::class, 'index']);
             Route::post('', [TableEditorController::class, 'update']);
 

routes/console.php

@@ -6,15 +6,13 @@
 use NotFound\Framework\Services\Indexer\IndexBuilderService;
 
 Artisan::command('siteboss:index-site {--debug : Whether debug messages should be displayed} {--clean : Truncate search table}', function ($debug, $clean) {
-
     $indexer = new IndexBuilderService($debug, $clean);
     $indexer->run();
 
     return Command::SUCCESS;
 })->purpose('Index site for local search');
 
 Artisan::command('siteboss:cms-import {--debug : Whether debug messages should be displayed} {--dry : Dry Run}', function ($debug, $dry) {
-
     $indexer = new ExchangeConsoleService($debug, $dry);
     $indexer->import();