Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default path & content header change for selenium 4 #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shaqtsui
Copy link

default path & content header change for selenium 4

Description

selenium 4 have changed host path from "/wd/hub" -> ""
also content-type header need to have charset included.
another bug about WDError construction:
json.value -> json

Some test case can not be execute, as the test dendent page is not available anymore.
But manual tests done.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@terasakisatoshi
Copy link

@Nosferican @shaqtsui
This PR should be useful for those who want to use selenium 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants