Fixed compiler warning -Werror=enum-int-mismatch #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an error running your pipeline, see logs for details. |
4 tasks
|
@cf-bottom jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11444/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11444/ |
craigcomstock
requested changes
Nov 21, 2024
|
There was an error running your pipeline, see logs for details. |
The function LogToSystemLog now takes an int as the log level, although the desired type would be the enum "LogLevel". For some C compilers, the last required argument must be self-promoting: that is, the default promotions must not change its type (this is actually an ISO C requirement). However, enums promote to an int. Thus, we cannot use them and must use int instead. Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <[email protected]> Co-authored-by: Craig Comstock <[email protected]>
|
There was an error running your pipeline, see logs for details. |
craigcomstock
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik [email protected]