Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all aiohttp.ContentTypeError occurrences #228

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Nov 3, 2024

Summary

Basically ignore all aiohttp.ContentTypeError occurrences within the tree. This way, we still get a response back for the user saying that we can't parse their query, and it's emitted into stderr for tracking purposes. But we don't send back another response with the usual FullEmbedError contents so this hides the invalid query and doesn't give more information than necessary.

Types of changes

What types of changes does your code introduce to Catherine-Chan
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 changed the title ignore all content type errors Ignore all aiohttp.ContentTypeError occurrences Nov 3, 2024
Copy link

sonarqubecloud bot commented Nov 3, 2024

@No767 No767 merged commit c7ee771 into main Nov 3, 2024
12 checks passed
@No767 No767 deleted the noelle/check-for-content branch November 3, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant