Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Correct MSTL tutorial #888

Merged
merged 2 commits into from
Aug 26, 2024
Merged

hotfix: Correct MSTL tutorial #888

merged 2 commits into from
Aug 26, 2024

Conversation

MMenchero
Copy link
Contributor

@MMenchero MMenchero commented Aug 23, 2024

Description

Corrected seasonal_length in MSTL model after a user on Slack reported seeing unusual results for the prediction intervals. With this fix, intervals now look ok. Closes #887.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez
Copy link
Member

@MMenchero FYI you can add some text to the description to automatically close an issue when a PR is merged (docs). So adding something like "closes #887" anywhere in the description will close that issue when this is merged.

@MMenchero
Copy link
Contributor Author

Thank you, @jmoralez. I wasn't aware that the user had opened an issue, so I'll make sure to review them to prevent this in the future.

@MMenchero MMenchero merged commit 29f4734 into main Aug 26, 2024
19 checks passed
@MMenchero MMenchero deleted the fix/mstl-tutorial branch August 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatsForecast: MSTL - confidence level gives same result as the point estimate - bug
2 participants