Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: keep target dtype in output #865

Merged
merged 8 commits into from
Sep 12, 2024
Merged

enh: keep target dtype in output #865

merged 8 commits into from
Sep 12, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jun 28, 2024

Respects the data type of the input for the predictions, so if the user provides a float64 target the predictions are also float64, same for float32. If the targets are integers then we convert them to float32.

Fixes #806

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title keep target dtype in output enh: keep target dtype in output Sep 12, 2024
@jmoralez jmoralez marked this pull request as ready for review September 12, 2024 23:45
@jmoralez jmoralez merged commit 9cf7424 into main Sep 12, 2024
29 checks passed
@jmoralez jmoralez deleted the output-dtype branch September 12, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeasonalNaive forecasts are not as expected; expected lag 12 but forecast is rounded and slightly off
1 participant