Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to correct link for installation from polars walkthrough #684

Closed
wants to merge 3 commits into from
Closed

Update to correct link for installation from polars walkthrough #684

wants to merge 3 commits into from

Conversation

DaveParr
Copy link
Contributor

@DaveParr DaveParr commented Nov 2, 2023

Link to installation doc was broken. Think I've found where it lives now.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@DaveParr DaveParr changed the title Main Update to correct link for installation from polars walkthrough Nov 2, 2023
@jmoralez
Copy link
Member

Hey @DaveParr, thanks for the fix! About the extras tip, I think it might be better to have a dedicated section in the install page listing all the extras, kind of like pandas does. I think that could be done in a separate PR. What do you think?

@DaveParr
Copy link
Contributor Author

Hey @DaveParr, thanks for the fix! About the extras tip, I think it might be better to have a dedicated section in the install page listing all the extras, kind of like pandas does. I think that could be done in a separate PR. What do you think?

Sure, do you want t revert 20fc3b7 then and shall I put a new page together for it?

@jmoralez
Copy link
Member

Sure, do you want t revert 20fc3b7

Yes, please.

shall I put a new page together for it?

I think it's best if it's in the installation page and just in a different section like "Optional dependencies". We can then add bullets or subsections with each of the extras that can be installed.

@DaveParr
Copy link
Contributor Author

DaveParr commented Nov 29, 2023

Looks like this doc has had a re-write and the broken link is now corrected.

Happy to close this :)

@DaveParr DaveParr closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants