-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate core processing to utilsforecast #656
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, @jmoralez! Abstracting GroupedArray
in utilsforecast
is a really cool effort. The code now is more navigable. 🎉
I just had a question regarding using unique_id
as an index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed on maintaining the warnings
for more time to allow users to change their code. 🙌
df
to the StatsForecast constructor.sort_df
argument (in utilsforecast we sort if needed).df
in the constructor in the fugue methods.