-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] New structure #323
[DOCS] New structure #323
Conversation
elephaint
commented
Apr 30, 2024
- New structure for TimeGPT documentation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
@AzulGarza, this is ready for review. |
Quick question @elephaint (and @AzulGarza ). From what I understand, the order of the documents in the sidebar from readme.com is given by the slug flag passed in the create readme script. Right now the order is given by increasing the |
Good point, this was actually a thing I was still exploring / tinkering with. In the mint.json, I tried to force the order that I wanted, but just did not yet find out how to enforce it for the sidebar. Also because I was tinkering with subgroups there (see updated mint.json). I wanted to avoid explicit file ordering except for the high level structure because I thought it maybe easier for future additions. Also, I noticed that in the rendered readme often blank lines in the notebooks are ignored, as well as some bullet lists. So there is still a lot of reformatting to do (but that can be done separately from having the structure in place already). |
Makes sense @elephaint. Let's see what @AzulGarza thinks. But if she agrees, I'm ok with merging this PR and creating a new one that deals specifically with ordering nbs inside the subfolders. I think ultimately, being able to define the order makes a lot of sense. |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
thanks @elephaint @mergenthaler!
i agree, i think we should also fix some rendering issues with the images. eg hierarchical: i'm merging this pr to have the new structure in main and iterating on that. |