iterm2: 3.5.10 -> 3.5.11 #370402
Merged
iterm2: 3.5.10 -> 3.5.11 #370402
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaskorz
added
the
1.severity: security
github-actions
bot
added
10.rebuild-darwin: 0
LeSuisse
approved these changes
Jan 4, 2025
DimitarNestorov
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Works fine for me
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 370402
aarch64-darwin
✅ 1 package built:
- iterm2
|
Thanks for the confirmation! |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-370402-to-release-24.11 origin/release-24.11
cd .worktree/backport-370402-to-release-24.11
git switch --create backport-370402-to-release-24.11
git cherry-pick -x 2ce46489b3ebc4903355f05ab33f1458ed860b80 |
|
@DimitarNestorov 3.5.10 thankfully wasn't backported to 24.11. Ideally you'd create a manual backport PR cherry-picking the update commits from both PRs (so the vulnerable version isn't backported in isolation). |
13 tasks
|
Manual backport: #370837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a critical security issue in iTerm2's ssh integration: https://iterm2.com/downloads/stable/iTerm2-3_5_11.changelog
nixpkgs-24.11 is not affected (has 3.5.4)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.