-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xpraWithNvenc: add nvjpeg support #370396
base: master
Are you sure you want to change the base?
Conversation
Oh I forgot nixfmt |
57fc71a
to
3c23fe6
Compare
594b7b0
to
989cef1
Compare
|
please at least show me the error. it built for me. also, please tell me which version of nixpkgs you are on. |
I am going to run again tho |
I've seen this one, but only on some versions of nixpkgs. For some r eason, the cuda kernels can only be compiled on some versions, likely due to changing cudatoolkit versions. I have no idea how to fix this. This is a nvenc problem strictly, and the nvjpeg version works fine. Maybe the nvjpeg version should be spun off into its own option? |
Python has a way to pass a different stdenv and CUDA packages are built using their own stdenv. |
Please clarify what this means exactly. I don't know what "python has a different way to pass stdenv" means and when it comes to CUDA, should I make a separate package with the CUDA builder which only compiles the cuda kernels? |
|
989cef1
to
a5ad720
Compare
Alright, try now |
a5ad720
to
fa948a3
Compare
It's in the queue to run overnight here. |
It built for me! Thanks for the suggestion. I will get to your changes, fix the merge conflict, then you can review it tomorrow. |
acaafc7
to
a1334b9
Compare
|
Well, some packages that I didn't make didn't build. But xpraWithNvenc did! So uh, it should be fine |
This is a bug in nixpkgs-review that somehow stacks diffs of PRs and only happens with --eval local. I disabled this flag and queued it up again. |
f71ccf2
to
4f9eccf
Compare
4f9eccf
to
2f11ac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test the additions as I don't have suitable hardware. But I can attest that 2f11ac3 functions normally in my (non-nvenc) setup.
I have a 3060 but idk how can I test it locally. |
I've tested it with my 2060. You can test it by running |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.