-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
high-tide: init at 0.1.0 #370085
base: master
Are you sure you want to change the base?
high-tide: init at 0.1.0 #370085
Conversation
2045002
to
ed39f4a
Compare
ed39f4a
to
7418ef8
Compare
preFixup = '' | ||
gappsWrapperArgs+=( | ||
# XDG_CACHE_HOME needs to be set, or high-tide will save images to its working dir. | ||
--prefix XDG_CACHE_HOME : "/tmp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else seems okay but...
Should we be overriding this? (i assume most DEs would set it automatically?)
But even then, as per XDG specs XDG_CACHE should probably point to a directory in ~/.cache
and not /tmp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also lead to the client re-downloading the images on every boot if /tmp
is mounted on top of tmpfs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XDG_CACHE_HOME wasn't set for me on Hyprland, I could move it to .cache though I wasn't sure if $HOME/.cache is the correct "nix" way to do that or if there is a nix way to get the user home dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea it's not set for me either.. hmm
i think that /tmp
is okay as well, but $HOME/.cache
is probably preferable over that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with
gappsWrapperArgs+=(
# XDG_CACHE_HOME needs to be set, or high-tide will save images to its working dir.
--prefix XDG_CACHE_HOME : "$HOME/.cache"
)
High tide crashes with:
./HighTide
Fontconfig error: No writable cache directories
Fontconfig error: No writable cache directories
Traceback (most recent call last):
File "/nix/store/2afapcyiwmmxp13281n58xhvq8rrxnzb-high-tide-0.1.0/bin/.HighTide-wrapped", line 46, in <module>
sys.exit(main.main(VERSION))
^^^^^^^^^^^^^^^^^^
File "/nix/store/2afapcyiwmmxp13281n58xhvq8rrxnzb-high-tide-0.1.0/share/HighTide/high_tide/main.py", line 140, in main
app = TidalApplication()
^^^^^^^^^^^^^^^^^^
File "/nix/store/2afapcyiwmmxp13281n58xhvq8rrxnzb-high-tide-0.1.0/share/HighTide/high_tide/main.py", line 47, in __init__
variables.init()
File "/nix/store/2afapcyiwmmxp13281n58xhvq8rrxnzb-high-tide-0.1.0/share/HighTide/high_tide/lib/variables.py", line 28, in init
os.makedirs(IMG_DIR)
File "<frozen os>", line 215, in makedirs
File "<frozen os>", line 215, in makedirs
File "<frozen os>", line 225, in makedirs
PermissionError: [Errno 13] Permission denied: '/homeless-shelter'
Running strings HighTide
it appears that nix is changing $HOME
to /homeless-shelter
:
/homeless-shelter/.cache
XDG_CACHE_HOME
This might have been the reason I made it cache in /tmp
before and I just forgot. Not sure if there is a different way to do this.
closes: #369825
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.