git-trim: add missing zlib dependency #369536
Merged
+7
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
paparodeo
reviewed
Dec 31, 2024
| @@ -46,6 +47,7 @@ rustPlatform.buildRustPackage rec { | |||
| IOKit | |||
| CoreFoundation | |||
| Security | |||
| zlib | |||
There was a problem hiding this comment.
#369535 (comment). can make zlib unconditional ( and drop IOKit CoreFoundation and Security -- they are no-ops now as they are part of the stdenv)
There was a problem hiding this comment.
ah cool! will fixup - thanks for the callouts!
There was a problem hiding this comment.
When removing Security from the top level attrset, i get an error in eval - i guess because this is invoked with
git-trim = darwin.apple_sdk_11_0.callPackage ../applications/version-management/git-trim {...}in all-packages.nix - is that something i should swap out for the main callPackage now?
There was a problem hiding this comment.
I've made this ^ change and made sure it built
jpetrucciani
force-pushed
the
fixup_git-trim
branch
from
cb25130 to
fad39b5
Compare
jpetrucciani
changed the title
jpetrucciani
force-pushed
the
fixup_git-trim
branch
from
fad39b5 to
c05c30a
Compare
github-actions
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
paparodeo
approved these changes
Dec 31, 2024
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #366745, there appears to be a missing
zlibdep for this package on darwin. Adding this allows the build to succeed again!Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.