Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: fix darwin build #369517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Dec 30, 2024

Add patches for bundled libraries (rnp and libsexpp) to handle clang 19 lack of char_traits for unsigned char.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Add patches for bundled libraries (rnp and libsexpp) to handle clang 19
lack of char_traits for unsigned char.
@booxter booxter force-pushed the thunderbird-fix-darwin-clang-19 branch from e08a33b to 34b5b9a Compare December 31, 2024 00:55
@booxter booxter marked this pull request as ready for review December 31, 2024 01:59
@booxter booxter marked this pull request as draft December 31, 2024 02:28
@booxter
Copy link
Contributor Author

booxter commented Dec 31, 2024

Converted back to draft for now since apparently I can avoid including patches by fetchpatching them. Will update.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 31, 2024
@ofborg ofborg bot requested review from nbp, vcunat and lovesegfault December 31, 2024 11:03
@booxter
Copy link
Contributor Author

booxter commented Dec 31, 2024

It's impossible to de-vendorize these patches because what we can fetchpatch doesn't apply cleanly (stupidly, because of a conflict on a Copyright header). So we'll keep these patches as-is in-tree.

@booxter booxter marked this pull request as ready for review December 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant