Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.periodiq: 0.12.1 -> 0.13.0 #369382

Merged
merged 1 commit into from
Dec 30, 2024
Merged

python3Packages.periodiq: 0.12.1 -> 0.13.0 #369382

merged 1 commit into from
Dec 30, 2024

Conversation

traxys
Copy link
Contributor

@traxys traxys commented Dec 30, 2024 •
edited
Loading

Diff: https://gitlab.com/bersace/periodiq/-/compare/v0.12.1...v0.13.0

Things done

  • Built on platform(s)

    • x86_64-linux

    • aarch64-linux

    • x86_64-darwin

    • aarch64-darwin

  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@traxys
Copy link
Contributor Author

traxys commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369382

x86_64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

@traxys traxys marked this pull request as ready for review December 30, 2024 12:50
@traxys traxys requested a review from GaetanLepage December 30, 2024 12:50
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 30, 2024
@GaetanLepage GaetanLepage changed the title python3.pkgs.periodiq: 0.12.1 -> 0.13.0 python3Packages.periodiq: 0.12.1 -> 0.13.0 Dec 30, 2024
GaetanLepage
GaetanLepage requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename the commit to python3Packages.periodiq: 0.12.1 -> 0.13.0
  • Add
  nativeCheckInputs = [
    pytestCheckHook
    pytest-mock
    versionCheckHook
  ];
  versionCheckProgramArg = [ "--version" ];

pkgs/development/python-modules/periodiq/default.nix Outdated
@@ -22,14 +22,13 @@ buildPythonPackage rec {
owner = "bersace";
repo = "periodiq";
rev = "v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369382

x86_64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

aarch64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

x86_64-darwin

❌ 10 packages failed to build:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

aarch64-darwin

❌ 10 packages failed to build:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

@traxys
Copy link
Contributor Author

traxys commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369382

x86_64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369382

x86_64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

aarch64-linux

✅ 10 packages built:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

x86_64-darwin

❌ 10 packages failed to build:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

aarch64-darwin

❌ 10 packages failed to build:
  • fittrackee
  • fittrackee.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist
  • python313Packages.flask-dramatiq
  • python313Packages.flask-dramatiq.dist
  • python313Packages.periodiq
  • python313Packages.periodiq.dist

@GaetanLepage GaetanLepage merged commit e48e3c0 into NixOS:master Dec 30, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traxys @GaetanLepage