avro-cpp: 1.11.3 -> 1.12.0, enable tests, libserdes: fix build with avro-cpp 1.12.0 #369338
+57
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major change to the public API. Now avro-cpp public headers depend on fmt as well as boost. The build system tries to do FetchContent on fmtlib unconditionally, which requires patching to circumvent. Looks like the least painful thing to do is to propagate both boost and fmt and hope that dependant packages don't break too much.
Unit tests are built unconditionally by the build system. Might as well run them, since they take very little time to execute.
|
|
Looks like this breaks libserdes on darwin. |
Some finagling is required to make the configure scripts cooperate with the required bump to the minimum C++ standard version. avro-cpp needs at least C++17, but libserdes is stuck at C++11.
xokdvium
force-pushed
the
dev/avro-cpp-bump
branch
from
23c68dd to
4e6e0ae
Compare
|
khaneliman
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update gets pretty ugly because of the new dependency on fmt, which needs some patching and finagling.
Release notes: https://github.com/apache/avro/releases/tag/release-1.12.0.
Resolves #368981.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.