liblas: fix build with boost 1.86 #369334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imincik
force-pushed
the
liblas-pin-boost
branch
from
9feeb37 to
4808642
Compare
paparodeo
reviewed
Dec 30, 2024
There was a problem hiding this comment.
alternatively can fix the compile error by removing `-std=c++98'.
diff --git a/pkgs/by-name/li/libLAS/package.nix b/pkgs/by-name/li/libLAS/package.nix
index 5bec9b5f2075..f5e3ce2b0e84 100644
--- a/pkgs/by-name/li/libLAS/package.nix
+++ b/pkgs/by-name/li/libLAS/package.nix
@@ -45,6 +45,11 @@ stdenv.mkDerivation rec {
})
];
+ postPatch = ''
+ substituteInPlace CMakeLists.txt \
+ --replace-fail 'set(CMAKE_CXX_FLAGS "''${CMAKE_CXX_FLAGS} -std=c++98 -ansi")' '#'
+ '';
+
nativeBuildInputs = [ cmake ] ++ lib.optional stdenv.hostPlatform.isDarwin fixDarwinDylibNames;
buildInputs = [
boost
Thank you @paparodeo , looks as a good idea. |
ofborg
bot
added
11.by: package-maintainer
|
I guess the problem is related to dropped support of C++98 in boost 1.84.0. |
|
Disable setting of C++98 standard which was dropped in boost 1.84.0. Co-authored-by: Reno Dakota <[email protected]
imincik
force-pushed
the
liblas-pin-boost
branch
from
4808642 to
aaffc2c
Compare
|
@paparodeo , I replaced my fix with yours. Thank you ! Please review. |
|
Result of 1 package built:
|
@lucasew , looks like this report belongs to some other PR. |
paparodeo
approved these changes
Dec 31, 2024
|
Great thanks for help @paparodeo . |
It looks like a ZFS issue. It's probably fixed by now. |
imincik
added a commit
to imincik/geospatial-nix.repo
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable setting of C++98 standard which was dropped in boost 1.84.0.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.