Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atuin: 18.3.0 -> 18.4.0 #369322

Merged
merged 2 commits into from
Dec 30, 2024
Merged

atuin: 18.3.0 -> 18.4.0 #369322

merged 2 commits into from
Dec 30, 2024

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Dec 30, 2024 •
edited by adamcstephens
Loading

Things done

See https://github.com/atuinsh/atuin/releases/tag/v18.4.0

Closes #368682

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 30, 2024
@r-vdp
Copy link
Contributor Author

r-vdp commented Dec 30, 2024 •
edited
Loading

Ugh, forgot to run the formatter. I'll do that in a bit.

Edit: done.

@poopsicles poopsicles mentioned this pull request Dec 30, 2024
Closed
@r-vdp
Copy link
Contributor Author

r-vdp commented Dec 30, 2024

@ofborg build atuin atuin.tests

@nadir-ishiguro
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369322

x86_64-linux

✅ 1 package built:
  • atuin

@adamcstephens
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369322

aarch64-linux

✅ 1 package built:
  • atuin

aarch64-darwin

✅ 1 package built:
  • atuin

@adamcstephens
Copy link
Contributor

FYI @r-vdp I updated the description with a Closes instead of Replaces since that's a keyword to trigger automatic action on merge.

@adamcstephens adamcstephens merged commit d836dc6 into master Dec 30, 2024
36 of 40 checks passed
@adamcstephens adamcstephens deleted the atuin branch December 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadir-ishiguro nadir-ishiguro nadir-ishiguro approved these changes

@0x4A6F 0x4A6F Awaiting requested review from 0x4A6F

@Sciencentistguy Sciencentistguy Awaiting requested review from Sciencentistguy

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-vdp @nadir-ishiguro @adamcstephens