Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifold: 3.0.0 -> 3.0.1 #369309

Merged
merged 1 commit into from
Dec 30, 2024
Merged

manifold: 3.0.0 -> 3.0.1 #369309

merged 1 commit into from
Dec 30, 2024

Conversation

pca006132
Copy link
Contributor

Updated manifold from v3.0.0 to v3.0.1 with some bug fixes and performance improvements.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pca006132 pca006132 requested a review from hzeller December 30, 2024 05:48
@pca006132 pca006132 mentioned this pull request Dec 30, 2024
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 30, 2024
@pbsbot
Copy link

pbsbot commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369309

x86_64-linux

✅ 2 packages built:
  • manifold
  • openscad-unstable

@pbsds pbsds merged commit 0b2d91f into NixOS:master Dec 30, 2024
43 of 44 checks passed
@hzeller
Copy link
Contributor

hzeller commented Dec 30, 2024

Belated LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzeller hzeller Awaiting requested review from hzeller

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pca006132 @pbsbot @hzeller @pbsds