weblate: 5.8.3 -> 5.9.2 and fix #369307
Open
weblate: 5.8.3 -> 5.9.2 and fix #369307
+169
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukium
force-pushed
the
weblate/update
branch
from
edcdb0a to
c98b4a8
Compare
|
erictapen
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Thanks for the work! I got stuck at making fedora-messaging work in my attempt.
Asking as a person not super familiar with python packaging, is using the GitHub source generally preferred over Pypi tarballs? I always figured it would be the other way round.
Btw feel free to list me as maintainer in the packages you added, I try to maintain Weblate and its dependencies.
|
|
||
| pyproject = true; | ||
|
|
||
| disabled = python.pythonOlder "3.11"; |
There was a problem hiding this comment.
Why remove this? Upstream says the same thing https://github.com/WeblateOrg/weblate/blob/main/pyproject.toml#L167C1-L167C27
| ]; | ||
|
|
||
| pythonImportsCheck = [ "crochet" ]; | ||
|
|
There was a problem hiding this comment.
Suggested change
| nativeCheckInputs = [ pytestCheckHook ]; |
I noticed crochet has pytest tests.
This was referenced Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/WeblateOrg/weblate_schemas/blob/2024.2/CHANGES.rst
Changelog: https://github.com/WeblateOrg/translation-finder/blob/2.19/CHANGES.rst
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.