Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: update a few defaults #369242

Merged
merged 3 commits into from
Jan 3, 2025
Merged

nextcloud: update a few defaults #369242

merged 3 commits into from
Jan 3, 2025
+22 −8

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 29, 2024 •
edited
Loading

Please review by commit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 requested review from bachp, dotlambda and Atemu December 29, 2024 21:58
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 29, 2024
@Ma27 Ma27 requested a review from Atemu December 30, 2024 16:05
@Ma27 Ma27 force-pushed the nc-default-dbtype branch from a9c5641 to 24529b9 Compare December 30, 2024 23:00
Ma27 added 3 commits December 31, 2024 00:01
@Ma27
nixos/nextcloud: drop default for dbtype setting
c7ccfc5 
Closes NixOS#355606

To quote the system requirements[1]:

> Database: SQLite 3.16+ (only recommended for testing and minimal-instances)

As discussed[2], this would already fail at eval-time for everyone and
makes all sqlite users aware that this is probably not the best choice.
Doing that regardless, is now an explicit decision.

[1] https://docs.nextcloud.com/server/30/admin_manual/installation/system_requirements.html
[2] NixOS#369242 (comment)
@Ma27
nixos/nextcloud: increase pool settings
6978b4b 
Also link to upstream docs about PHP-FPM tuning[1].
These seem a little more reasonable performance-wise, but are still
conservative enough for small setups.

[1] https://docs.nextcloud.com/server/30/admin_manual/installation/server_tuning.html#tune-php-fpm
@Ma27
nixos/nextcloud: don't use pg14 for tests
b95a917 
This currently fails to build, so we just update it now to make sure all
tests are green with the current changes.
@Ma27 Ma27 force-pushed the nc-default-dbtype branch from 24529b9 to b95a917 Compare December 30, 2024 23:05
@Ma27
Copy link
Member Author

Ma27 commented Jan 1, 2025 •
edited
Loading

@Atemu are you fine with the current state? I'm inclined to submit this tomorrow unless there are more things to discuss.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 1, 2025
Atemu
Atemu approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the other changes but the diff w.r.t. DB default LGTM.

@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jan 1, 2025
@SuperSandro2000 SuperSandro2000 merged commit fd92a48 into NixOS:master Jan 3, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@bachp bachp bachp approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ma27 @bachp @SuperSandro2000 @Shawn8901 @Atemu @wegank