sane-frontends: fix gcc14 compilation #369228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
paparodeo
reviewed
Dec 29, 2024
There was a problem hiding this comment.
LGTM. the commit message needs to be changed as there is a somewhat strict policy: sane-frontends: fix gcc14 compilation
https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
timhae
force-pushed
the
fix-gcc14-sane-frontends
branch
from
eacfe5e to
73c5709
Compare
github-actions
bot
added
10.rebuild-darwin: 0
timhae
changed the title
emilazy
approved these changes
Dec 30, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patches from fedora to compile with gcc14 without errors, fixes #369155
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.